-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Array.Sort test combinations, per #41234 #41376
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsShould we have more test combinations, given this involves the complexity of pivots, etc? Originally posted by @danmosemsft in #41234 (comment)
|
Hello! I want to help. But I don't know how to start. I am new at the repo. |
@DDolG you'll need to check the internal implementation details of the sort function and try to understand it. The particular piece mentioned in the other PR is referring to pivot from the intro sort - See https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ArraySortHelper.cs#L473 - you will need to pick data which will exercise all branches of that code |
*Added tests for sorting arrays *Separated tests for integer from string *Added comments for integers and strings
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsShould we have more test combinations, given this involves the complexity of pivots, etc? Originally posted by @danmosemsft in #41234 (comment)
|
Should we have more test combinations, given this involves the complexity of pivots, etc?
Originally posted by @danmosemsft in #41234 (comment)
The text was updated successfully, but these errors were encountered: