-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build runtime repo on Windows with ninja #45763
Comments
If this is due to some recent changes in the C++ compiler installed with the new VS, @janvorli may need to take a look to figure out the proper way to adjust the cmake files to be backward-compatible. |
Reading the docs here, can we just disable |
Well that seemed to work, but it looks like there's something wrong with the DAC: I get the error It looks like it's trying to consume a Linux DAC even though this is building on Windows. Do we build a cross dac by default? |
Adding @sdmaclea |
Yes this looks like it is due to building the linux cross dac for Windows. I'll take a look. |
This is still not fully fixed for me - on latest master it fails with: 'C:/ProgramData/chocolatey/bin/ninja.exe' '-C' 'F:/dotnet/runtime2/artifacts/obj/native/net6.0-windows-Debug-x64' '-t' 'cleandead'
failed with:
ninja : error : build.ninja:945: multiple rules generate System.IO.Compression.Native/System.IO.Compression.Native.lib [-w dupbuild=err] [F:\dotnet\runtime2\src\libraries\Native\build-native.proj] |
cc: @VSadov since he most recently changed how we build System.IO.Compression.Native |
The library was renamed on windows. It used to be |
The System.IO.Compression.Native.lib issue was apparently fixed by 5761dd4 |
Now fails with a different error: -- Build files have been written to: F:/dotnet/runtime2/artifacts/obj/native/net6.0-windows-Debug-x64
[1/94] Building C object System.IO.Compression.Native\CMakeFiles\System.IO.Compression.Native.dir\F_\dotnet\runtime2\src\libraries\Native\AnyOS\brotli\common\context.c.obj
cl : Command line error D9025: overriding '/W0' with '/W3' [F:\dotnet\runtime2\src\libraries\Native\build-native.proj]
cl : Command line error D9025: overriding '/MDd' with '/MTd' [F:\dotnet\runtime2\src\libraries\Native\build-native.proj] |
Yeah I see the same here. |
Clean clone of the runtime repo, Windows 10, latest VS dogfood, running
build.cmd -ninja
from root:while building
src/coreclr/pal/src/libunwind
The text was updated successfully, but these errors were encountered: