Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building the crossdacs with ninja. #46089

Merged
1 commit merged into from
Dec 15, 2020
Merged

Conversation

jkoritzinsky
Copy link
Member

This will fix running ./build clr -ninja from the command line to build as well as enable us to use Ninja for building the whole product.

We were accidentally setting __BuildNative=1 here from when the -ninja option was created based on the usenmakemakefiles option.

Contributes to #44761

@hoyosjs
Copy link
Member

hoyosjs commented Dec 15, 2020

cc: @sdmaclea

@sdmaclea
Copy link
Contributor

/cc @vitek-karas

@hoyosjs
Copy link
Member

hoyosjs commented Dec 15, 2020

@sdmaclea are these well known?

2020-12-15T20:14:26.0787787Z [24/477] Building C object pal\src\libunwind\src\CMakeFiles\libunwind_xdac.dir\x86_64\Gapply_reg_state.c.obj
2020-12-15T20:14:26.0788859Z cl : Command line warning D9014 : invalid value '9025' for '/wd'; assuming '5999'

@sdmaclea
Copy link
Contributor

sdmaclea commented Dec 15, 2020

I think that was introduced by #45902

add_compile_options(-wd9025) # overriding '/TP' with '/TC'

I wanted to suppress the D9025 warning reported in #45763. Not sure if it worked at all because that type of error was scattered everywhere with the VS Preview dogfood compilers. The line could be removed if it is not helpful.

@ghost
Copy link

ghost commented Dec 15, 2020

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ea98282 into dotnet:master Dec 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
@jkoritzinsky jkoritzinsky deleted the crossdac-ninja branch January 21, 2021 19:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants