Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for * Assertion at /Users/runner/work/1/s/src/mono/mono/metadata/marshal-ilgen.c:6204, condition `sig->param_count == invoke_sig->param_count + 1' not met #46926

Closed
rolfbjarne opened this issue Jan 13, 2021 · 2 comments
Assignees
Milestone

Comments

@rolfbjarne
Copy link
Member

I recently ran into this assert in the AOT compiler:

  • Assertion at /Users/runner/work/1/s/src/mono/mono/metadata/marshal-ilgen.c:6204, condition `sig->param_count == invoke_sig->param_count + 1' not met

g_assert (sig->param_count == invoke_sig->param_count + 1);

This was due to a bug in my code, but it took me quite a while to figure out where the problem was, because the assert doesn't give any information as to where in the invalid assembly I should even start looking.

In other words: the bug is that this assert should show information about the type/method in question that causes the problem, which would make it much easier to figure out where the problem is.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 13, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 23, 2021
@imhameed imhameed modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@SamMonoRT SamMonoRT assigned SamMonoRT and unassigned imhameed Mar 1, 2022
@SamMonoRT SamMonoRT modified the milestones: 7.0.0, 8.0.0 Aug 4, 2022
@SamMonoRT SamMonoRT assigned naricc and unassigned SamMonoRT Aug 4, 2022
@SamMonoRT SamMonoRT assigned jandupej and unassigned naricc Apr 10, 2023
jandupej added a commit to jandupej/runtime that referenced this issue Jun 2, 2023
lewing pushed a commit that referenced this issue Jul 12, 2023
* Expanding error message in #46926

* Removing unnecessary code.
@jandupej
Copy link
Member

Addressed in #88726. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants