AppleAppBuilder doesn't embed test data from subdirectories

[filipnavara]

Some test assemblies rely on test data being compiled into the published app. One example is System.Security.Cryptography.X509Certificates which copies several test certificates into the TestData directory.

AppleAppBuilder currently doesn't copy these data into the app bundle so the tests fail to find the data.

Notably, this code doesn't list files in subdirectories:

runtime/src/tasks/AppleAppBuilder/Xcode.cs

Lines 66 to 69 in 6b71dd2

	string[] resources = Directory.GetFiles(workspace)
	.Where(f => !excludes.Any(e => f.EndsWith(e, StringComparison.InvariantCultureIgnoreCase)))
	.Concat(Directory.GetFiles(binDir, "*.aotdata"))
	.ToArray();

Fixing that is relatively easy but CMake still flattens out the resource structure in the output Xcode project.

[ghost]

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Some test assemblies rely on test data being compiled into the published app. One example is System.Security.Cryptography.X509Certificates which copies several test certificates into the TestData directory.

AppleAppBuilder currently doesn't copy these data into the app bundle so the tests fail to find the data.

Notably, this code doesn't list files in subdirectories:

runtime/src/tasks/AppleAppBuilder/Xcode.cs

Lines 66 to 69 in 6b71dd2

	string[] resources = Directory.GetFiles(workspace)
	.Where(f => !excludes.Any(e => f.EndsWith(e, StringComparison.InvariantCultureIgnoreCase)))
	.Concat(Directory.GetFiles(binDir, "*.aotdata"))
	.ToArray();

Fixing that is relatively easy but CMake still flattens out the resource structure in the output Xcode project.

Author:	filipnavara
Assignees:	-
Labels:	area-System.Security, untriaged
Milestone:	-

[ghost]

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Some test assemblies rely on test data being compiled into the published app. One example is System.Security.Cryptography.X509Certificates which copies several test certificates into the TestData directory.

AppleAppBuilder currently doesn't copy these data into the app bundle so the tests fail to find the data.

Notably, this code doesn't list files in subdirectories:

runtime/src/tasks/AppleAppBuilder/Xcode.cs

Lines 66 to 69 in 6b71dd2

	string[] resources = Directory.GetFiles(workspace)
	.Where(f => !excludes.Any(e => f.EndsWith(e, StringComparison.InvariantCultureIgnoreCase)))
	.Concat(Directory.GetFiles(binDir, "*.aotdata"))
	.ToArray();

Fixing that is relatively easy but CMake still flattens out the resource structure in the output Xcode project.

Author:	filipnavara
Assignees:	-
Labels:	area-Infrastructure-mono, untriaged
Milestone:	-

[directhex]

As best I can determine, CMake isn't entirely to blame here. Xcode flattens all file references in Resources. If you want a directory structure, you need a folder reference, which is handled differently (and obviously means we can't filter the files the way we do in xcode.cs)

Will run some experiments

[directhex]

OK, I've determined that RESOURCE in cmakelists always takes the flattening approach. It seems there's a slightly different MACOSX_PACKAGE_LOCATION which works with subdirectories. Gotta get the syntax right...

[directhex]

Xcode is cursed