-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metadata-update] Add support for deltas with CustomAttributes modifications #52993
Comments
dotnet-issue-labeler
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
May 19, 2021
This was referenced May 19, 2021
marek-safar
removed
the
untriaged
New issue has not been triaged by the area owner
label
Jun 2, 2021
We would also need to support deletion of custom attributes, perhaps using the EnCLog Delete function code #53635 |
lambdageek
changed the title
[metadata-update] Add support for adding custom attributes
[metadata-update] Add support for deltas with CustomAttributes modifications
Jun 2, 2021
In particular, we may need to be able to consume the various annotations that get emitted for nullability. |
27 tasks
lambdageek
added a commit
to lambdageek/runtime
that referenced
this issue
Nov 30, 2022
…r async The async test was marked with the CustomAttributes tracking issue, but it's actually unrelated. Fixes dotnet#52993
This is actually done - we already say we support the capability. There were just some tests that haven't been enabled. I have a PR to remove the ActiveIssues |
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Nov 30, 2022
ghost
removed
the
in-pr
There is an active PR which will close this issue when it is merged
label
Dec 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Dec 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For methods/classes/etc.
In
mono_custom_attrs_from_index_checked
we need to do a proper iteration that uses a metadata-update aware bounds check, at least. (see the FIXME).Note that normally the CustomAttribtues table is assumed sorted by the Parent column and assumed contiguous for a given parent. So if we add new attributes for an existing parent or new parents that are out of order with respect to the existing table, we will need some lookaside table on a slow path.
The correlated CoreCLR issue is #53066 (and in particular the comments with some tables that show what can go wrong)
Contributes to #57365
The text was updated successfully, but these errors were encountered: