Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.DotNet.PackageTesting is hardcoding OS and arch values #53521

Closed
ViktorHofer opened this issue Jun 1, 2021 · 2 comments
Closed

Microsoft.DotNet.PackageTesting is hardcoding OS and arch values #53521

ViktorHofer opened this issue Jun 1, 2021 · 2 comments
Assignees
@Anipik
Labels
area-Infrastructure-libraries
Milestone
6.0.0

Comments

@ViktorHofer
Copy link
Member

See this section: https://github.com/dotnet/arcade/blob/c7d6bd607715f334cda90e01967bb0c02dee09be/src/Microsoft.DotNet.PackageTesting/GetCompatiblePackageTargetFrameworks.cs#L143-L150.

The PackageTesting logic should not hardcode the child values for Unix and also not assume that every OS offers an x64 architecture. In general it would be best if the OS and the Architecture isn't hardcoded at all.

cc @Anipik @ericstj
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 1, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

See this section: https://github.com/dotnet/arcade/blob/c7d6bd607715f334cda90e01967bb0c02dee09be/src/Microsoft.DotNet.PackageTesting/GetCompatiblePackageTargetFrameworks.cs#L143-L150.

The PackageTesting logic should not hardcode the child values for Unix and also not assume that every OS offers an x64 architecture. In general it would be best if the OS and the Architecture isn't hardcoded at all.

cc @Anipik @ericstj

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged
Milestone: -

@Anipik Anipik self-assigned this Jun 1, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Jun 1, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 1, 2021
@ericstj
Copy link
Member

ericstj commented Jul 26, 2021

I believe this was fixed in dotnet/arcade#7510

@ericstj ericstj closed this as completed Jul 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Anipik Anipik

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@ViktorHofer @ericstj @Anipik