Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Object mode for package testing & remove older frameworks & rids #7510

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Change Object mode for package testing & remove older frameworks & rids #7510

merged 6 commits into from
Jun 14, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Jun 10, 2021

  • use nuget content model for package object similar to package validation.
  • remove out of support frameworks.
  • remove rids metadata as we no longer need.
  • modify tests

Anipik added 2 commits June 11, 2021 10:26
…ll supported frameworks and add min dotnet version for packages contatining netstandard config
@ViktorHofer
Copy link
Member

Cool. You are missing the props file which defines the current set of tfms:

  • netstandard2.0
  • netstandard2.1
  • net461-net48
  • netcoreapp3.1
  • net5.0
  • net6.0

@Anipik
Copy link
Contributor Author

Anipik commented Jun 13, 2021

Cool. You are missing the props file which defines the current set of tfms:

shouldnt this be set in the runtime repo ? so that when the tfms go out of support we can just change the property in the runtime repo.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 14, 2021

shouldnt this be set in the runtime repo ? so that when the tfms go out of support we can just change the property in the runtime repo.

Projects that live in arcade are meant to be consumed by multiple repositories. Moving the current set of supported TFMs into a props file a) makes it easier for multiple repositories to use the package and b) allows consumers to mutate that list.

Imagine a repository like dotnet/runtime that versions to the next version of .NETCoreApp and wants to do that independently of the current set of exposed supported TFMs in this package.

In example dotnet/runtime versions from .NET 6 to .NET 7 and can add this code block temporarily to avoid a change in the package itself:

<ItemGroup>
   <SupportedTargetFramework Remove="netcoreapp3.1" />
   <SupportedTargetFramework Remove="net5.0" />
   <SupportedTargetFramework Include="net7.0" />
</ItemGroup>

At a later point these changes will then flow back into this package to keep the defined TFMs consistent with the .NET support policy.

@@ -3,4 +3,8 @@
<DotNetPackageTestingAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)..\tools\net472\Microsoft.DotNet.PackageTesting.dll</DotNetPackageTestingAssembly>
<DotNetPackageTestingAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tools\netcoreapp3.1\Microsoft.DotNet.PackageTesting.dll</DotNetPackageTestingAssembly>
</PropertyGroup>

<ItemGroup>
<SupportedTestFramework Include="netcoreapp3.1;net5.0;net6.0;net461;net462;net471;net472;net48;netstandard2.0;netstandard2.1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SupportedTargetFramework is currently set by the sdk and it contains all the frameworks so i defined it as SupportedTestFramework

@@ -3,4 +3,8 @@
<DotNetPackageTestingAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)..\tools\net472\Microsoft.DotNet.PackageTesting.dll</DotNetPackageTestingAssembly>
<DotNetPackageTestingAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tools\netcoreapp3.1\Microsoft.DotNet.PackageTesting.dll</DotNetPackageTestingAssembly>
</PropertyGroup>

<ItemGroup>
<SupportedTestFramework Include="netcoreapp3.1;net5.0;net6.0;net461;net462;net471;net472;net48;netstandard2.0;netstandard2.1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are missing test coverage in the test assembly as when I tried to add net6.0 last time, the NuGet Parse mechanism blew up. Can you please add a test that passes these items in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants