Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back StructWithPublicDefaultConstructor test #58639

Closed
eerhardt opened this issue Sep 3, 2021 · 1 comment · Fixed by #65616
Closed

Add back StructWithPublicDefaultConstructor test #58639

eerhardt opened this issue Sep 3, 2021 · 1 comment · Fixed by #65616
Labels
area-Extensions-DependencyInjection help wanted [up-for-grabs] Good issue for external contributors
Milestone
7.0.0

Comments

@eerhardt
Copy link
Member

eerhardt commented Sep 3, 2021

With the discussion in #49069, we removed the StructWithPublicDefaultConstructor test in #49133 in order to not ship the TestStructs assembly.

Now that C# 10 has parameterless constructors in struct support, we can make this test without depending on the TestStructs assembly. We should add this test back.
@eerhardt eerhardt added this to the 7.0.0 milestone Sep 3, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 3, 2021
@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

With the discussion in #49069, we removed the StructWithPublicDefaultConstructor test in #49133 in order to not ship the TestStructs assembly.

Now that C# 10 has parameterless constructors in struct support, we can make this test without depending on the TestStructs assembly. We should add this test back.

Author: eerhardt
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: 7.0.0

@eerhardt eerhardt removed the untriaged New issue has not been triaged by the area owner label Sep 3, 2021
@maryamariyan maryamariyan added the help wanted [up-for-grabs] Good issue for external contributors label Dec 23, 2021
@pedrobsaila pedrobsaila mentioned this issue Feb 19, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 19, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Extensions-DependencyInjection help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add back StructWithPublicDefaultConstructor test pedrobsaila/runtime
2 participants
@maryamariyan @eerhardt