Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back StructWithPublicDefaultConstructor test #65616

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Add back StructWithPublicDefaultConstructor test #65616

merged 1 commit into from
Feb 22, 2022

Conversation

pedrobsaila
Copy link
Contributor

Fixes #58639

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 19, 2022
@ghost
Copy link

ghost commented Feb 19, 2022

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58639

Author: pedrobsaila
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: -

eerhardt
eerhardt approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@eerhardt
Copy link
Member

Test failure was in FileWatcher on OSX - unrelated to this change.

@eerhardt eerhardt merged commit 59f90aa into dotnet:main Feb 22, 2022
@pedrobsaila pedrobsaila deleted the 58639 branch February 22, 2022 20:49
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back StructWithPublicDefaultConstructor test
2 participants
@pedrobsaila @eerhardt