Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment failing #64188

Closed
radical opened this issue Jan 24, 2022 · 18 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono disabled-test The test is disabled in source code against the issue test-failure
Milestone

Comments

@radical
Copy link
Member

radical commented Jan 24, 2022

Failing on rolling build - Build, and Log

[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:37767/devtools/page/79E663E76834EA440CBAB0CD2CAB2BDB
[21:35:25] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
[21:35:27] info: DebuggerTests.Inspector[0] runtime ready, TEST TIME
[21:35:27] info: DebuggerTests.Inspector[0] console.log: ready
[21:35:27] fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::9 -> [Result: IsOk: False, IsErr: True, Value: , Error: {   "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'" } ]
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] RunLoop stopped, reason: Shutdown. (parentToken: True, linked: True): 
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Failing 0 pending cmds
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Loop ended with socket: Aborted
[21:35:27] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] Proxy done
[xUnit.net 00:00:15.58]     DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [FAIL]
[21:35:28] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] connecting to ws://localhost:9400/launch-chrome-and-connect
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:36459/devtools/page/1075ADF29D9088A2E8B9BF6E78493EBB
[21:35:28] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
  Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [153 ms]
  Error Message:
   [Runtime.getProperties returned False instead of True, for {
  "objectId": "dotnet:scope:1"
}, with Result: [Result: IsOk: False, IsErr: True, Value: , Error: {
  "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'"
} ]]

Expected: True
Actual:   False
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1058
   at DebuggerTests.DebuggerTestBase.GetProperties(String id, JToken fn_args, Nullable`1 own_properties, Nullable`1 accessors_only, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 835
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 512
   at DebuggerTests.DebuggerTestBase.StepAndCheck(StepKind kind, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, Int32 times) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 472
   at DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(String clazz, JObject checkDefault, JObject checkValue) in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 48
--- End of stack trace from previous location ---

The runtime is asserting at https://github.com/dotnet/runtime/blob/main/src/mono/mono/component/debugger-agent.c#L2195:

...
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
...

This was hit on the rolling build for 4a6d169 but was working on the previous build for 5605bdf , and the new commit being: 4a6d169

Add runtime support for ref fields (#63985)
* Add mono and coreclr runtime support for ref fields

* Update Reflection.Emit tests to validate ref fields.

Add test for TypedReference as a ref field.

cc @AaronRobinsonMSFT

{
    "ErrorMessage": "Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment",
    "BuildRetry": false
}

Report

Build Definition Test Pull Request
291985 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
291509 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86722
291438 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86813
291252 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86501
290651 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84512
290344 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86925
286567 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
286566 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
286306 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86664
285659 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
285663 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
284376 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
283355 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86278
280613 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
278935 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #85558
276439 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #84191
275141 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86255
274058 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86255
271904 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #86152
267595 dotnet/runtime chrome-DebuggerTests.AssignmentTests.WorkItemExecution #85730

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
1 6 20
@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Jan 24, 2022
@ghost
Copy link

ghost commented Jan 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Failing on rolling build - Build, and Log

[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:25] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:37767/devtools/page/79E663E76834EA440CBAB0CD2CAB2BDB
[21:35:25] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
[21:35:27] info: DebuggerTests.Inspector[0] runtime ready, TEST TIME
[21:35:27] info: DebuggerTests.Inspector[0] console.log: ready
[21:35:27] fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::9 -> [Result: IsOk: False, IsErr: True, Value: , Error: {   "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'" } ]
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] RunLoop stopped, reason: Shutdown. (parentToken: True, linked: True): 
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Failing 0 pending cmds
[21:35:27] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Loop ended with socket: Aborted
[21:35:27] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] Proxy done
[xUnit.net 00:00:15.58]     DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [FAIL]
[21:35:28] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] connecting to ws://localhost:9400/launch-chrome-and-connect
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[21:35:28] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:36459/devtools/page/1075ADF29D9088A2E8B9BF6E78493EBB
[21:35:28] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
  Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [153 ms]
  Error Message:
   [Runtime.getProperties returned False instead of True, for {
  "objectId": "dotnet:scope:1"
}, with Result: [Result: IsOk: False, IsErr: True, Value: , Error: {
  "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'"
} ]]

Expected: True
Actual:   False
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1058
   at DebuggerTests.DebuggerTestBase.GetProperties(String id, JToken fn_args, Nullable`1 own_properties, Nullable`1 accessors_only, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 835
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 512
   at DebuggerTests.DebuggerTestBase.StepAndCheck(StepKind kind, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, Int32 times) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 472
   at DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(String clazz, JObject checkDefault, JObject checkValue) in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 48
--- End of stack trace from previous location ---

The runtime is asserting at https://github.com/dotnet/runtime/blob/main/src/mono/mono/component/debugger-agent.c#L2195:

...
[21:35:27] info: DebuggerTests.Inspector[0] console.trace: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
[21:35:27] info: DebuggerTests.Inspector[0] console.error: * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met 
...

This was hit on the rolling build for 4a6d169 but was working on the previous build for 5605bdf , and the new commit being: 4a6d169

Add runtime support for ref fields (#63985)
* Add mono and coreclr runtime support for ref fields

* Update Reflection.Emit tests to validate ref fields.

Add test for TypedReference as a ref field.

cc @AaronRobinsonMSFT

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 24, 2022
@radical radical added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 24, 2022
@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Jan 24, 2022

@lambdageek or @fanyang-mono I'm going to need some help here. I've no idea why the ref field changes would have impacted a test related to debugger stepping around enum assignment. The test that is failing is

async Task InspectVariableBeforeAndAfterAssignment(string clazz, JObject checkDefault, JObject checkValue)

The code being executed under that test is

public class MONO_TYPE_ENUM
{
public static int Prepare()
{
RGB value = RGB.Blue;
return StepInTest<RGB>.TestedMethod(value);
}
}

@radical
Copy link
Member Author

radical commented Jan 24, 2022

Cc @thaystg

@thaystg thaystg self-assigned this Jan 24, 2022
@thaystg
Copy link
Member

thaystg commented Jan 24, 2022

I'm working on it.

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jan 24, 2022
@lewing lewing added this to the 7.0.0 milestone Jan 24, 2022
@thaystg
Copy link
Member

thaystg commented Jan 24, 2022

@AaronRobinsonMSFT it's possibly unrelated with that commit. Still working on it.

@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 24, 2022
@radical
Copy link
Member Author

radical commented Jan 24, 2022

I didn't see the failure on the subsequent rolling build, so removing blocking-clean-ci label.

@radical
Copy link
Member Author

radical commented Jan 30, 2022

Seeing this on windows too - log.

console.trace: * Assertion at D:/a/_work/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met

console.error: * Assertion at D:/a/_work/1/s/src/mono/mono/component/debugger-agent.c:2195, condition `<disabled>' not met

@sbomer sbomer added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 31, 2022
@sbomer
Copy link
Member

sbomer commented Jan 31, 2022

This is continuing to show up in rolling builds - see the associated builds in the original issue up top. Do we have confirmation that it's introduced by the ref field changes? Could we revert the changes that are causing these or temporarily disable the tests to unblock ci?

@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 31, 2022
@runfoapp runfoapp bot removed this from the 7.0.0 milestone Feb 2, 2022
@runfoapp runfoapp bot closed this as completed Feb 2, 2022
@radical radical reopened this Feb 2, 2022
@robertmclaws
Copy link

Just an FYI, this issue is not limited to just the testing framework. I'm experiencing it at runtime in my Blazor apps.

@radical
Copy link
Member Author

radical commented Feb 6, 2022

Can you please file a separate issue with the details?

@robertmclaws
Copy link

I can, I just wanted to point out that the problem is not in the test runners themselves but in .NET 6.0. IN case you were trying to trace down a test problem.

@radical
Copy link
Member Author

radical commented Feb 23, 2022

I haven't seen this recently, but hit it today on #63894 . build:

[18:22:14] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] connecting to ws://localhost:9400/launch-chrome-and-connect
[18:22:14] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[18:22:15] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:49729/devtools/page/7FC16A3E6124A3AE52D98214E18F7A98
[18:22:15] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
[18:22:15] info: DebuggerTests.Inspector[0] console.warning: Warning: Unable to read debug information of: debugger-test-with-full-debug-type.dll (use DebugType=Portable/Embedded)
[18:22:16] info: DebuggerTests.Inspector[0] console.log: ready
[18:22:16] info: DebuggerTests.Inspector[0] runtime ready, TEST TIME
[18:22:16] fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::9 -> [Result: IsOk: False, IsErr: True, Value: , Error: {   "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'" } ]
[18:22:16] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] RunLoop stopped, reason: Shutdown. (parentToken: False, linked: False): 
[18:22:16] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] Proxy done
[18:22:16] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Failing 0 pending cmds
[18:22:16] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] Loop ended with socket: CloseSent
[18:22:16] dbug: Microsoft.WebAssembly.Diagnostics.InspectorClient[0] connecting to ws://localhost:9400/launch-chrome-and-connect
[18:22:16] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] New test request
[xUnit.net 00:00:22.05]     DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_VALUETYPE", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [FAIL]
[18:22:16] info: Microsoft.WebAssembly.Diagnostics.TestHarnessProxy[0] launching proxy for ws://127.0.0.1:49810/devtools/page/7B9400DFDB63B32330514453EC0D9033
[18:22:16] info: DebuggerTests.Inspector[0] waiting for the runtime to be ready
  Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_VALUETYPE", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]]) [289 ms]
  Error Message:
   [Runtime.getProperties returned False instead of True, for {
  "objectId": "dotnet:scope:1"
}, with Result: [Result: IsOk: False, IsErr: True, Value: , Error: {
  "message": "Unable to RuntimeGetProperties 'dotnet:scope:1'"
} ]]

Expected: True
Actual:   False
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1081
   at DebuggerTests.DebuggerTestBase.GetProperties(String id, JToken fn_args, Nullable`1 own_properties, Nullable`1 accessors_only, Boolean expect_ok) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 858
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 535
   at DebuggerTests.DebuggerTestBase.StepAndCheck(StepKind kind, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, Int32 times) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 472
   at DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(String clazz, JObject checkDefault, JObject checkValue) in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 48
--- End of stack trace from previous location ---

This time

  • it is for MONO_TYPE_VALUETYPE
  • no assertions

@thaystg thaystg added this to the 7.0.0 milestone Jul 5, 2022
@radical radical modified the milestones: 7.0.0, 8.0.0 Aug 11, 2022
@radical
Copy link
Member Author

radical commented Oct 4, 2022

This is being hit again, but with a different error:

[xUnit.net 00:03:31.48]     DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]], methodName: "DebuggerTests.StepInTest<DebuggerTests.RGB>.Tested"...) [FAIL]
  Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM", checkDefault: [[[...]], [[...]], [[...]], [[...]]], checkValue: [[[...]], [[...]], [[...]], [[...]]], methodName: "DebuggerTests.StepInTest<DebuggerTests.RGB>.Tested"...) [84 ms]
  Error Message:
   Assert.Equal() Failure
Expected: 2
Actual:   1
  Stack Trace:
     at DebuggerTests.AssignmentTests.<>c__DisplayClass3_0.<<InspectVariableBeforeAndAfterAssignment>b__0>d.MoveNext() in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 58
--- End of stack trace from previous location ---
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 621
   at DebuggerTests.DebuggerTestBase.StepAndCheck(StepKind kind, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, Int32 times) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 555
   at DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(String clazz, JObject checkDefault, JObject checkValue, String methodName) in /_/src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs:line 55
--- End of stack trace from previous location ---
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:539:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": [
    {
      "scriptId": "dotnet://27312_1",
      "lineNumber": 542,
      "columnNumber": 8
    }
  ]
}, Error:  ]
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:1272:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": []
}, Error:  ]

Also here.

@radical radical added the Known Build Error Use this to report build issues in the .NET Helix tab label Oct 4, 2022
radical added a commit to radical/runtime that referenced this issue Oct 5, 2022
Issue: dotnet#64188

`DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM"...`

- And add some debug bits to help with debugging this on CI.
radical added a commit that referenced this issue Oct 5, 2022
* [wasm] Disable failing debugger test

Issue: #64188

`DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment(clazz: "MONO_TYPE_ENUM"...`

- And add some debug bits to help with debugging this on CI.

* cleanup
@radical radical added the disabled-test The test is disabled in source code against the issue label Oct 5, 2022
@radical
Copy link
Member Author

radical commented Nov 15, 2022

@missymessa I looked at the top few builds referenced in the Report (in the PR description), and I don't see the failure "ErrorMessage": "DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment". None of them had this failure but they still show up here. What is it matching then? (I did look at the previous attempts too)

Example - https://dev.azure.com/dnceng-public/public/_build/results?buildId=82673&view=results, and https://dev.azure.com/dnceng-public/public/_build/results?buildId=82735&view=results.

@ulisesh
Copy link
Contributor

ulisesh commented Nov 28, 2022

The error message has to improve, build analysis will match this known issue with any failed build or test that contains the string DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment. For example, this build

A better error message would be Failed DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment

@radical radical removed the Known Build Error Use this to report build issues in the .NET Helix tab label Jun 1, 2023
@radical
Copy link
Member Author

radical commented Jun 1, 2023

I have removed the known build error label because we don't have a unique string to match this error. The current one being used matches any failure in this test, and that can end up covering other unrelated genuine failures.

@lewing
Copy link
Member

lewing commented Jul 10, 2023

@thaystg what is the status on this one?

@thaystg
Copy link
Member

thaystg commented Jul 11, 2023

I will close this one, me and @radical haven't seen this recently.

@thaystg thaystg closed this as completed Jul 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono disabled-test The test is disabled in source code against the issue test-failure
Projects
None yet
Development

No branches or pull requests

7 participants