[wasm] running tests on NodeJs fails with globalThis is not defined

[radical]

Hitting this on the emscripten bump PR.
Build:

[01:27:29] fail: /datadisks/disk1/work/A3DA08F7/w/B1B30976/e/test-main.js:97
[01:27:29] fail: if (typeof globalThis.crypto === 'undefined') {
[01:27:29] fail: ^
[01:27:29] fail: 
[01:27:29] fail: ReferenceError: globalThis is not defined
[01:27:29] fail:     at Object.<anonymous> (/datadisks/disk1/work/A3DA08F7/w/B1B30976/e/test-main.js:97:1)
[01:27:29] fail:     at Module._compile (internal/modules/cjs/loader.js:778:30)
[01:27:29] fail:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
[01:27:29] fail:     at Module.load (internal/modules/cjs/loader.js:653:32)
[01:27:29] fail:     at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
[01:27:29] fail:     at Function.Module._load (internal/modules/cjs/loader.js:585:3)
[01:27:29] fail:     at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
[01:27:29] fail:     at startup (internal/bootstrap/node.js:283:19)
[01:27:29] fail:     at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
[01:27:29] info: Process node exited with 1

I'm disabling nodejs test runs for that PR.

cc @pavelsavara @maraf

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Hitting this on the emscripten bump PR.
Build:

[01:27:29] fail: /datadisks/disk1/work/A3DA08F7/w/B1B30976/e/test-main.js:97
[01:27:29] fail: if (typeof globalThis.crypto === 'undefined') {
[01:27:29] fail: ^
[01:27:29] fail: 
[01:27:29] fail: ReferenceError: globalThis is not defined
[01:27:29] fail:     at Object.<anonymous> (/datadisks/disk1/work/A3DA08F7/w/B1B30976/e/test-main.js:97:1)
[01:27:29] fail:     at Module._compile (internal/modules/cjs/loader.js:778:30)
[01:27:29] fail:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
[01:27:29] fail:     at Module.load (internal/modules/cjs/loader.js:653:32)
[01:27:29] fail:     at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
[01:27:29] fail:     at Function.Module._load (internal/modules/cjs/loader.js:585:3)
[01:27:29] fail:     at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
[01:27:29] fail:     at startup (internal/bootstrap/node.js:283:19)
[01:27:29] fail:     at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
[01:27:29] info: Process node exited with 1

I'm disabling nodejs test runs for that PR.

cc @pavelsavara @maraf

Author:	radical
Assignees:	-
Labels:	arch-wasm, area-Build-mono
Milestone:	-

[lewing]

I'm not sure what is happening here but it looks like a node specific case at this point, @maraf please work with @radekdoulik to look into it

[pavelsavara]

This looks like the new nodeJS version (which we get from emsdk) is not used. Why ?

[maraf]

The new emscripten has a newer version of node, which is in different folder (14.15.5_64bit -> 14.18.2_64bit) and we have the path hardcoded in the sendtohelix-wasm.targets. I have pushed this change to the PR branch.

[radekdoulik]

Could we avoid hardcoding the version number?

[pavelsavara]

Also please add something like this to test-main.js

if (node && process.versions.node.split(".")[0]<14) throw new Error("NodeJS at "+process.execPath+"has too low version" + process.versions.node);

So that we don't have think about why, next time.

[maraf]

Could we avoid hardcoding the version number?

I'll try to read it from filesystem in #65514.

So that we don't have think about why, next time.

In PR #65549.

[radical]

Just a heads up, that we are now running tests on nodejs only on PRs. Once this is fixed, we could enable that for rolling builds.

[maraf]

Both PRs I mentioned are merged. I think we can close this one.