-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[armel/tizen] Broken build #73571
Comments
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsDescriptionTizen armel build is broken after #73095 Reproduction Steps
Expected behaviorBuild should pass Actual behavior
Regression?yes Known WorkaroundsRevert PR ConfigurationNo response Other information
|
A quick fix is to skip diff --git a/eng/Subsets.props b/eng/Subsets.props
index 45b2a49471e..bcd4a8c09bc 100644
--- a/eng/Subsets.props
+++ b/eng/Subsets.props
@@ -52,6 +52,7 @@
<PropertyGroup>
<DefaultCoreClrSubsets>clr.native+linuxdac+clr.corelib+clr.tools+clr.nativecorelib+clr.packages+clr.nativeaotlibs+clr.crossarchtools+host</DefaultCoreClrSubsets>
+ <DefaultCoreClrSubsets Condition="'$(PackageRID)' == 'linux-armel'">clr.native+linuxdac+clr.corelib+clr.tools+clr.nativecorelib+clr.packages+clr.nativeaotlibs+clr.crossarchtools</DefaultCoreClrSubsets>
<!-- Even on platforms that do not support the CoreCLR runtime, we still want to build ilasm/ildasm. -->
<DefaultCoreClrSubsets Condition="'$(PrimaryRuntimeFlavor)' != 'CoreCLR'">clr.iltools+clr.packages</DefaultCoreClrSubsets> then the build succeeds. The real issue is that tizen build is a special case that it uses both non-PortableBuild and CrossBuild simultaneously: ( |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsDescriptionTizen armel build is broken after #73095 Reproduction Steps
Expected behaviorBuild should pass Actual behavior
Regression?yes Known WorkaroundsRevert PR ConfigurationNo response Other information
|
Fix armel/Tizen build dotnet#73571
Fix armel/Tizen build #73571 Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Looks like this was fixed by #73625 |
Description
Tizen armel build is broken after #73095
Reproduction Steps
Expected behavior
Build should pass
Actual behavior
Regression?
yes
Known Workarounds
Revert PR
Configuration
No response
Other information
cc @jkotas @gbalykov
The text was updated successfully, but these errors were encountered: