-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure baseservices\\exceptions\\unittests\\RecursiveThrowNew\\RecursiveThrowNew.cmd #75944
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsRun: runtime-coreclr jitstress 20220919.1 Failed test:
Error message:
|
One more assert in rationalize. Assigning to @BruceForstall. @jakobbotsch PTAL. |
Looks related to #75842, apparently the threading added there was not enough (or perhaps incorrect). I'll look into a fix tomorrow. |
Wonder if the failures we now see in #62689 are also related. |
Seems like it is from changes made in |
Under jit stress, `optOptimizeBoolsGcStress` will modify trees. Since this now happens in a phase that runs after `fgSetBlockOrder`, it must also recost and rethread the trees. Fixes dotnet#75944.
This is not a 7.0 issue. |
In some cases the value of a block's branch predicate is correlated with the predecessor of the block. Often this correlation is hinted at by the presence of phis in the predicate's tree and/or phi VNs in in the predicate's VN graph. For each predecessor of a block, we evaluate the predicate value number using the values brought to the block by that predecessor. If we find correlations, we use them to drive the existing jump threading optimization. Also, if we end up partially disambiguating such that there is just one remaining predecessor, update the value number of the predicate to reflect the values that flow in from that predecessor. Fixes dotnet#75944. Contributes to dotnet#48115.
In some cases the value of a block's branch predicate is correlated with the predecessor of the block. Often this correlation is hinted at by the presence of phis in the predicate's tree and/or phi VNs in in the predicate's VN graph. For each predecessor of a block, we evaluate the predicate value number using the values brought to the block by that predecessor. If we find correlations, we use them to drive the existing jump threading optimization. Make sure that when we search local PHIs we also match the ssa def number to ensure we're looking at the right PHI. Also, if we end up partially disambiguating such that there is just one remaining predecessor, update the value number of the predicate to reflect the values that flow in from that predecessor. Fixes #75944. Contributes to #48115.
Run: runtime-coreclr jitstress 20220919.1
Failed test:
Error message:
The text was updated successfully, but these errors were encountered: