Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: review properties of jit helpers #7723

Open
AndyAyersMS opened this issue Mar 24, 2017 · 5 comments
Open

JIT: review properties of jit helpers #7723

AndyAyersMS opened this issue Mar 24, 2017 · 5 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@AndyAyersMS
Copy link
Member

Some helpers are missing explicit entries in the helper classifier code at HelperCallProperties::init(). Seems like we should adopt a policy where all helper properties are spelled out explicitly and the default case asserts, so when a new helper is added we know we should go add the properties.

For instance CORINFO_HELP_READYTORUN_GENERIC_HANDLE is not listed and calls to it likely can be removed if the result is unused.

category:cq
theme:helpers
skill-level:expert
cost:medium
@AndyAyersMS
Copy link
Member Author

CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE won't return null. The MAYBE_NULL variant will but isn't listed at all (perhaps not a big deal as it seems to only be used for TypedReference which is rare).

Also have seen several cases where we null check the result of a NEW helper, despite it being marked as returning an non-null value. Will try and update this issue with a specific example.

So perhaps there are cases where some properties aren't taken into account?

@AndyAyersMS
Copy link
Member Author

There's an example of null check after new in dotnet/coreclr#14472 -- the new is from an inlined box.

@AndyAyersMS
Copy link
Member Author

Considering this for 2.1, so changing milestone.

@AndyAyersMS
Copy link
Member Author

Probably not happening in time for 2.1, so pushing it out to Future once more.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Mar 27, 2020
@AndyAyersMS
JIT: allow CORINFO_HELP_READYTORUN_GENERIC_HANDLE to be optimized
0d6d4be 
This helper is idempotent and exception free, so enable it for value numbering.
Also, no need to spill the entire eval stack for a virtual stub calls.

Addresses part of dotnet#7723.
@AndyAyersMS AndyAyersMS mentioned this issue Mar 27, 2020
Merged
jkotas pushed a commit that referenced this issue Mar 28, 2020
@AndyAyersMS
JIT: allow CORINFO_HELP_READYTORUN_GENERIC_HANDLE to be optimized (#3…
e35a19c 
…4221)

This helper is idempotent and exception free, so enable it for value numbering.
Also, no need to spill the entire eval stack for a virtual stub calls.

Addresses part of #7723.
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@TIHan
Copy link
Contributor

TIHan commented Nov 1, 2023

Keeping this as future unless we believe we should review this for .NET 9.

@TIHan TIHan removed the JitUntriaged CLR JIT issues needing additional triage label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@TIHan @msftgits @AndyAyersMS @BruceForstall