Possible QuicConnection leak

[pepone]

This method is called during the disposal of the listener.

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicListener.PendingConnection.cs

Line 99 in 88f75a8

await _finishHandshakeTask.Task.ConfigureAwait(false);

If the _finishHandshakeTask task has already been completed successfully the QuicConnection held by this task is never disposed of, and this is the only reference left to it.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This method is called during the disposal of the listener.

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicListener.PendingConnection.cs

Line 99 in 88f75a8

await _finishHandshakeTask.Task.ConfigureAwait(false);

If the _finishHandshakeTask task has already been completed successfully the QuicConnection held by this task is never disposed of, and this is the only reference left to it.

Author:	pepone
Assignees:	-
Labels:	area-System.Net.Quic
Milestone:	-

[ManickaP]

Triage: looks like a legitimate bug, we should confirm this and fix it. It should be fairly simple fix.

[halter73]

There seems to be a similar issue any time PendingConnection.FinishHandshakeAsync gets canceled. While not ideal, hopefully the MsQuicContextSafeHandle at least cleans things up in either case, right?

[ManickaP]

Yep and yep, problem is the same with cancellation, and MsQuicContextSafeHandle cleans up eventually, after GC collects the main object.