-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUIC] Improved logic of listener AcceptConnection #82261
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAddresses several problems with accepting incoming connections:
Fixes #77310
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I left few comments but they can be done independently. (certainly the documentation)
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs
Show resolved
Hide resolved
and test failures seems relevant. |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Failures are unrelated. |
Addresses several problems with accepting incoming connections:
ListenBacklog
limit is enforced manually via_pendingConnectionsCapacity
_disposeCts
PendingConnection
class is now irrelevant thus removed,_acceptQueue
either containsQuicConnection
or anException
QuicException
Fixes #77310
Fixes #80172
Contributes to #78096