Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Improved logic of listener AcceptConnection #82261

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Feb 16, 2023

Addresses several problems with accepting incoming connections:

  • pending connections now don't get queued until the handshake is finished (whether successfully or not)
    • ListenBacklog limit is enforced manually via _pendingConnectionsCapacity
    • in case of listener disposal, the active handshakes get stopped via _disposeCts
    • PendingConnection class is now irrelevant thus removed, _acceptQueue either contains QuicConnection or an Exception
  • unexpected exception from handshake timeout is now wrapped in QuicException

Fixes #77310
Fixes #80172
Contributes to #78096

@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses several problems with accepting incoming connections:

Fixes #77310
Fixes #78096
Fixes #80172

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I left few comments but they can be done independently. (certainly the documentation)

@wfurt
Copy link
Member

wfurt commented Feb 17, 2023

and test failures seems relevant.

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

Failures are unrelated.

@ManickaP ManickaP merged commit 9ed6d99 into dotnet:main Feb 20, 2023
@ManickaP ManickaP deleted the mapichov/quic-listener-accept branch February 20, 2023 20:11
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible QuicConnection leak QuicListener.AcceptConnectionAsync usability
4 participants