[wasi] Enabling icu in wasi.proj breaks tests

[radical]

Based on #81052

With this patch to include the icu files in the runtime pack:

diff --git a/src/mono/wasi/wasi.proj b/src/mono/wasi/wasi.proj
index 836c68ae497..6ee8c2ccbb5 100644
--- a/src/mono/wasi/wasi.proj
+++ b/src/mono/wasi/wasi.proj
@@ -7,8 +7,8 @@

   <PropertyGroup>
     <!-- TODOWASI: icu support -->
-    <!--<ICULibDir Condition="'$(MonoWasmThreads)' != 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm', 'native', 'lib'))</ICULibDir>-->
-    <!--<ICULibDir Condition="'$(MonoWasmThreads)' == 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm-threads', 'native', 'lib'))</ICULibDir>-->
+    <ICULibDir Condition="'$(MonoWasmThreads)' != 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm', 'native', 'lib'))</ICULibDir>
+    <ICULibDir Condition="'$(MonoWasmThreads)' == 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm-threads', 'native', 'lib'))</ICULibDir>
     <WasmEnableSIMD Condition="'$(WasmEnableSIMD)' == ''">false</WasmEnableSIMD>
     <FilterSystemTimeZones Condition="'$(FilterSystemTimeZones)' == ''">false</FilterSystemTimeZones>
     <WasmObjDir>$(ArtifactsObjDir)wasm</WasmObjDir>
@@ -148,10 +148,10 @@
           DependsOnTargets="GenerateWasiPropsAndRspFiles;GenerateManagedToNative;BundleTimeZones">

     <ItemGroup>
-      <!--<ICULibNativeFiles Include="$(ICULibDir)/libicuuc.a;-->
-                                  <!--$(ICULibDir)/libicui18n.a;-->
-                                  <!--$(ICULibDir)/libicudata.a" />-->
-      <!--<ICULibFiles Include="$(ICULibDir)/*.dat" />-->
+      <ICULibNativeFiles Include="$(ICULibDir)/libicuuc.a;
+                                  $(ICULibDir)/libicui18n.a;
+                                  $(ICULibDir)/libicudata.a" />
+      <ICULibFiles Include="$(ICULibDir)/*.dat" />
     </ItemGroup>
     <PropertyGroup>
       <PInvokeTableFile>$(ArtifactsObjDir)wasm/pinvoke-table.h</PInvokeTableFile>

.. building a test project with:
./dotnet.sh build /bl src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj /p:Configuration=Release /p:TargetOS=wasi / p:TargetArchitecture=wasm /t:Test -p:WasmBuildNative=true -p:EnableAggressiveTrimming=true fails with:

  Performing WASI SDK build: "/workspaces/runtime/src/mono/wasi/wasi-sdk//bin/clang" @/workspaces/runtime/artifacts/obj/System.Buffers.Tests/Release/net8.0/wasi-wasm/wasm/for-publish/clang-compile.rsp
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicudata.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicui18n.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicuuc.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
clang-14 : error : linker command failed with exit code 1 (use -v to see invocation) [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
/workspaces/runtime/src/mono/wasi/build/WasiApp.Native.targets(440,5): error MSB3073: The command ""/workspaces/runtime/src/mono/wasi/wasi-sdk//bin/clang" @/workspaces/runtime/artifacts/obj/System.Buffers.Tests/Release/net8.0/wasi-wasm/wasm/for-publish/clang-compile.rsp" exited with code 1. [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]

cc @pavelsavara @mkhamoyan

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Based on #81052

With this patch to include the icu files in the runtime pack:

diff --git a/src/mono/wasi/wasi.proj b/src/mono/wasi/wasi.proj
index 836c68ae497..6ee8c2ccbb5 100644
--- a/src/mono/wasi/wasi.proj
+++ b/src/mono/wasi/wasi.proj
@@ -7,8 +7,8 @@

   <PropertyGroup>
     <!-- TODOWASI: icu support -->
-    <!--<ICULibDir Condition="'$(MonoWasmThreads)' != 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm', 'native', 'lib'))</ICULibDir>-->
-    <!--<ICULibDir Condition="'$(MonoWasmThreads)' == 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm-threads', 'native', 'lib'))</ICULibDir>-->
+    <ICULibDir Condition="'$(MonoWasmThreads)' != 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm', 'native', 'lib'))</ICULibDir>
+    <ICULibDir Condition="'$(MonoWasmThreads)' == 'true'">$([MSBuild]::NormalizeDirectory('$(PkgMicrosoft_NETCore_Runtime_ICU_Transport)', 'runtimes', 'wasi-wasm-threads', 'native', 'lib'))</ICULibDir>
     <WasmEnableSIMD Condition="'$(WasmEnableSIMD)' == ''">false</WasmEnableSIMD>
     <FilterSystemTimeZones Condition="'$(FilterSystemTimeZones)' == ''">false</FilterSystemTimeZones>
     <WasmObjDir>$(ArtifactsObjDir)wasm</WasmObjDir>
@@ -148,10 +148,10 @@
           DependsOnTargets="GenerateWasiPropsAndRspFiles;GenerateManagedToNative;BundleTimeZones">

     <ItemGroup>
-      <!--<ICULibNativeFiles Include="$(ICULibDir)/libicuuc.a;-->
-                                  <!--$(ICULibDir)/libicui18n.a;-->
-                                  <!--$(ICULibDir)/libicudata.a" />-->
-      <!--<ICULibFiles Include="$(ICULibDir)/*.dat" />-->
+      <ICULibNativeFiles Include="$(ICULibDir)/libicuuc.a;
+                                  $(ICULibDir)/libicui18n.a;
+                                  $(ICULibDir)/libicudata.a" />
+      <ICULibFiles Include="$(ICULibDir)/*.dat" />
     </ItemGroup>
     <PropertyGroup>
       <PInvokeTableFile>$(ArtifactsObjDir)wasm/pinvoke-table.h</PInvokeTableFile>

.. building a test project with:
./dotnet.sh build /bl src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj /p:Configuration=Release /p:TargetOS=wasi / p:TargetArchitecture=wasm /t:Test -p:WasmBuildNative=true -p:EnableAggressiveTrimming=true fails with:

  Performing WASI SDK build: "/workspaces/runtime/src/mono/wasi/wasi-sdk//bin/clang" @/workspaces/runtime/artifacts/obj/System.Buffers.Tests/Release/net8.0/wasi-wasm/wasm/for-publish/clang-compile.rsp
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicudata.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicui18n.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
wasm-ld : error : /workspaces/runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/libicuuc.a: archive has no index; run ranlib to add one [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
clang-14 : error : linker command failed with exit code 1 (use -v to see invocation) [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]
/workspaces/runtime/src/mono/wasi/build/WasiApp.Native.targets(440,5): error MSB3073: The command ""/workspaces/runtime/src/mono/wasi/wasi-sdk//bin/clang" @/workspaces/runtime/artifacts/obj/System.Buffers.Tests/Release/net8.0/wasi-wasm/wasm/for-publish/clang-compile.rsp" exited with code 1. [/workspaces/runtime/src/libraries/System.Buffers/tests/System.Buffers.Tests.csproj]

cc @pavelsavara @mkhamoyan

Author:	radical
Assignees:	-
Labels:	arch-wasm
Milestone:	8.0.0

[mkhamoyan]

Interesting when I copy lib files from my icu build to runtime/artifacts/bin/microsoft.netcore.app.runtime.wasi-wasm/Release/runtimes/wasi-wasm/native/ test is passing.

[mkhamoyan]

Will close once icu packages will be updated and tested on runtime.