[QUIC] Revisit exceptions in Quic

[ManickaP]

We have several exception issues cropping up for 8.0:

• QuicConnection.ConnectAsync raises SocketException when host not found #78751
• [API Proposal] QuicError.AcceptConnectionFailed #75184
• [QUIC] Surface transport error code in QuicException #72666
• QuicListener AcceptConnectionAsync and OperationCanceledException #78096
  • Partially fixed in [QUIC] Improved logic of listener AcceptConnection #82261

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We have several exception issues cropping up for 8.0:

• QuicConnection.ConnectAsync raises SocketException when host not found #78751
• [API Proposal] QuicError.AcceptConnectionFailed #75184
• [QUIC] Surface transport error code in QuicException #72666
• QuicListener AcceptConnectionAsync and OperationCanceledException #78096
  • Partially fixed in [QUIC] Improved logic of listener AcceptConnection #82261

Author:	ManickaP
Assignees:	-
Labels:	area-System.Net.Quic
Milestone:	-

[antonfirsov]

It would be also nice to distinguish name resolution errors and define QuicError.HostNotFound so we can have a unified name resolution error case in #76644.

[wfurt]

We agreed that we should:

• throw SocketException for transport problem e.g. for cases like MsQuic AddressInUse, HostUnreachable and InvalidAddress. That generally comes either as user error, host limitation and network conditions. That also covers cases when target name cannot be resolved to address.
• We will throw AuthenticationException for TLS and certificate related issues - preferably matching SslStream behavior.
• We will throw QuicException for reasons related to Quic protocol or processing specific to Quic.
• ArgumentException when supplied parameters or options provided by callback are not valid.
• OperationCanceledException for cases when processing fail because of cancellation.
• ObjectDisposedException for cases caused by disposing underlying object(s)

We shall document this in some way. Either reach consensus when dotnet/dotnet-api-docs#7840 is resolved, via remarks section or via examples.

[karelz]

@wfurt is there anything left here?

[wfurt]

While some work related to exceptions remains it is tracked by other issues. We reached agreement on strategy and that fulfills spirit to this issue IMHO