Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure exception count metric is thread-safe #85997

Closed
LakshanF opened this issue May 9, 2023 · 1 comment · Fixed by #86018
Closed

Ensure exception count metric is thread-safe #85997

LakshanF opened this issue May 9, 2023 · 1 comment · Fixed by #86018
Assignees
@LakshanF
Labels
area-System.Threading runtime-coreclr specific to the CoreCLR runtime
Milestone
8.0.0

Comments

@LakshanF
Copy link
Member

LakshanF commented May 9, 2023

We currently increment the counter in thread unsafe manner. See comment here related to that. Its good to be more accurate than the current implementation by using a thread-safe way to increment the count.

The current type is a uint32_t, where _InterlockedIncrement doesn't work without a cast in non-Windows and there is a pending request to change the API due to likely overflow of the current data type.
@LakshanF LakshanF added the runtime-coreclr specific to the CoreCLR runtime label May 9, 2023
@LakshanF LakshanF added this to the 8.0.0 milestone May 9, 2023
@LakshanF LakshanF self-assigned this May 9, 2023
@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

We currently increment the counter in thread unsafe manner. See comment here related to that. Its good to be more accurate than the current implementation by using a thread-safe way to increment the count.

The current type is a uint32_t, where _InterlockedIncrement doesn't work without a cast in non-Windows and there is a pending request to change the API due to likely overflow of the current data type.

Author: LakshanF
Assignees: LakshanF
Labels:

area-System.Threading, runtime-coreclr
Milestone: 8.0.0

@LakshanF LakshanF mentioned this issue May 9, 2023
Merged
jkotas added a commit to jkotas/runtime that referenced this issue May 9, 2023
@jkotas
Make exception count performance counter thread-safe
558a1ab 
Fixes dotnet#85997
@jkotas jkotas mentioned this issue May 9, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 9, 2023
jkotas added a commit that referenced this issue May 10, 2023
@jkotas
Make exception count performance counter thread-safe (#86018)
d7c2594 
Fixes #85997
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-System.Threading runtime-coreclr specific to the CoreCLR runtime
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Make exception count performance counter thread-safe jkotas/runtime
1 participant
@LakshanF