-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Investigate adding "phantom" replacements during physical promotion #87371
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBy phantom I mean making replacements of fields that we have not seen any uses of. There are at least two situations where this would be beneficial:
The potential benefits can be predicted by simply repeating physical promotion a number of times. In my experiments, repeating physical promotion 10 times results in -120K with physical promotion enabled, and -2 MB with old promotion disabled.
|
Add support for promoting fields based on the fact that assignment decomposition induces new field accesses. To do so we store all struct assignments that involve candidates for physical promotion as part of the initial accounting pass. Then when picking the replacements we do it as a fixpoint computation, iteratively expanding the set of replacements based on field accesses induced by decomposition assignment with the existing set of replacements. Fix dotnet#87371
…7410) Add support for promoting fields based on the fact that store decomposition induces new field accesses. To do so we store all struct stores that involve candidates for physical promotion as part of the initial accounting pass. Then when picking the replacements we do it as a fixpoint computation, iteratively expanding the set of replacements based on field accesses induced by store decomposition with the existing set of replacements. Fix #87371
By phantom I mean making replacements of fields that we have not seen any uses of. There are at least two situations where this would be beneficial:
The potential benefits can be predicted by simply repeating physical promotion a number of times. In my experiments, repeating physical promotion 10 times results in -120K with physical promotion enabled, and -2 MB with old promotion disabled.
The text was updated successfully, but these errors were encountered: