-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] AOT: System.Runtime.CompilerServices.Unsafe.Tests
- assertion - src/mono/mono/metadata/object.c:926
#89398
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsRolling build, and log:
.. and ..
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsRolling build, and log:
.. and ..
Changes since last passing rolling build - 2d1e284...65536eb which includes #85562 cc @MichalPetryka @vargaz Known Issue Error MessageFill the error message using step by step known issues guidance. {
"ErrorMessage": "",
"ErrorPattern": "",
"BuildRetry": false,
"ExcludeConsoleLog": false
}
|
This is a new test that was added in #85562, the PR itself didn't change anything in Mono. |
…s used with generic structures. Fixes dotnet#89398. For a method like ``` static void Write<T>(ref byte b, T value) => Unsafe.WriteUnaligned<T>(ref b, value); ``` And an instance ```Write<GStruct<string>>```, generic sharing will create a ```Write<T_INST>``` instance where T_INST is constrained to GStruct<T_REF>. The JIT currently calls ```mini_get_underlying_type ()``` in many places which transform T_INST into GStruct<T_REF>. This causes problems at runtime in the generic sharing code, which expects to find T_INST. I.e. ```inflate_info ()``` can inflate ```T_INST``` to ```GStruct<string>```, but it can't inflate ```GStruct<T_REF>``` to ```GStruct<string>```. As a workaround, disable gsharing in (some) of these cases.
…s used with generic structures. (#89417) Fixes #89398. For a method like ``` static void Write<T>(ref byte b, T value) => Unsafe.WriteUnaligned<T>(ref b, value); ``` And an instance ```Write<GStruct<string>>```, generic sharing will create a ```Write<T_INST>``` instance where T_INST is constrained to GStruct<T_REF>. The JIT currently calls ```mini_get_underlying_type ()``` in many places which transform T_INST into GStruct<T_REF>. This causes problems at runtime in the generic sharing code, which expects to find T_INST. I.e. ```inflate_info ()``` can inflate ```T_INST``` to ```GStruct<string>```, but it can't inflate ```GStruct<T_REF>``` to ```GStruct<string>```. As a workaround, disable gsharing in (some) of these cases.
Rolling build, and log:
.. and ..
Changes since last passing rolling build - 2d1e284...65536eb which includes #85562 cc @MichalPetryka @vargaz
Known Issue Error Message
Fill the error message using step by step known issues guidance.
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=349510
Error message validated:
/__w/1/s/src/mono/mono/metadata/object.c:926 <disabled>
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/24/2023 6:28:56 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: