Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2_MultipleConnectionsEnabled test failures #91075

Closed
MihaZupan opened this issue Aug 24, 2023 · 4 comments · Fixed by #91156
Closed

Http2_MultipleConnectionsEnabled test failures #91075

MihaZupan opened this issue Aug 24, 2023 · 4 comments · Fixed by #91156
Assignees
@MihaZupan
Labels
area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Milestone
8.0.0

Comments

@MihaZupan
Copy link
Member

MihaZupan commented Aug 24, 2023 •
edited by build-analysis bot
Loading

Related: #89788 that recently modified and/or re-enabled some of these tests

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=381149
Build error leg or test failing: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success
Pull request: #86194

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Http2_MultipleConnectionsEnabled",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=381149
Error message validated: Http2_MultipleConnectionsEnabled
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 8/24/2023 5:18:41 PM UTC

Report

Build Definition Step Name Console log Pull Request
387040 dotnet/runtime Send to Helix Log
385936 dotnet/runtime Send to Helix Log #90982
385389 dotnet/runtime Send to Helix Log #90517
385356 dotnet/runtime Send to Helix Log #91091
Build Definition Test Pull Request
390416 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ResponseDrain_Test.GetAsyncWithMaxConnections_DisposeLargerThanMaxDrainSize_KillsConnection
390421 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
390415 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ConnectionPooling_Test.HandlerDroppedWithoutDisposal_NotKeptAlive
389061 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
389063 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
387743 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
387729 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
387272 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
387273 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
386876 dotnet/runtime System.Net.Http.Functional.Tests.WorkItemExecution #91126
386867 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
386871 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
386600 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_IdleConnectionTimeoutExpired_ConnectionRemovedAndNewCreated_3 #91126
386209 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success_9 #91126
386034 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #85392
386015 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91116
385965 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91112
385885 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
385889 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
385886 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
385906 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #90880
385835 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success
385825 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91106
385736 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #90518
385733 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #90518
385719 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91106
385649 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91101
385559 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #90970
385396 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91092
385375 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91074
385364 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success
385334 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91094
385321 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #90551
385283 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success
385005 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #89102
384637 dotnet/runtime System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate
384505 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #91019
384350 dotnet/runtime System.Net.Http.Functional.Tests.HttpMetricsTest_Http30.RequestDuration_EnrichmentHandler_Success_Recorded #90518
381149 dotnet/runtime System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success #86194

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
3 42 43
@MihaZupan MihaZupan added area-System.Net.Http test-bug Problem in test source code (most likely) blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Aug 24, 2023
@MihaZupan MihaZupan added this to the 8.0.0 milestone Aug 24, 2023
@MihaZupan MihaZupan self-assigned this Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Related: #89788 that recently modified and/or re-enabled some of these tests

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=381149
Build error leg or test failing: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnections_Success
Pull request: #86194

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Http2_MultipleConnectionsEnabled",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net.Http, test-bug, blocking-clean-ci, Known Build Error
Milestone: 8.0.0

@richlander richlander mentioned this issue Aug 24, 2023
Merged
@MihaZupan MihaZupan mentioned this issue Aug 25, 2023
Merged
@MihaZupan MihaZupan added the disabled-test The test is disabled in source code against the issue label Aug 25, 2023
This was referenced Aug 25, 2023
Closed
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 26, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 29, 2023
@karelz
Copy link
Member

karelz commented Aug 29, 2023

@MihaZupan I assume we should backport it to 8.0 once we have confidence it addresses the test problem in main. How long should we observe based on past occurrence frequency?

@karelz karelz reopened this Aug 29, 2023
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Aug 29, 2023
@MihaZupan
Copy link
Member Author

MihaZupan commented Aug 29, 2023 •
edited
Loading

Looks like it only failed once on 8.0 branches, otherwise, it's passing on rerun ~2x a day.
I'd give it a week to be sure it's fully resolved.

@MihaZupan MihaZupan removed the disabled-test The test is disabled in source code against the issue label Aug 29, 2023
@MihaZupan MihaZupan mentioned this issue Aug 30, 2023
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Aug 30, 2023
@karelz
Copy link
Member

karelz commented Aug 31, 2023

Fixed in 9.0 (Main) in PR #91156 and in 8.0 (RC2) in PR #91343

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MihaZupan MihaZupan

Labels
area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix Http2 MultiConnection test race conditions MihaZupan/runtime
2 participants
@karelz @MihaZupan