Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Microsoft.BCL.Numerics package #91074

Merged
merged 10 commits into from
Aug 25, 2023
Merged

New Microsoft.BCL.Numerics package #91074

merged 10 commits into from
Aug 25, 2023

Conversation

michaelgsharp
Copy link
Member

Polyfills System.MathF in a new Microsoft.BCL.Numerics package.

@ghost ghost assigned michaelgsharp Aug 24, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@michaelgsharp
Copy link
Member Author

@tannergooding

@ghost
Copy link

ghost commented Aug 24, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Polyfills System.MathF in a new Microsoft.BCL.Numerics package.

Author: michaelgsharp
Assignees: michaelgsharp
Labels:

area-System.Numerics, new-api-needs-documentation
Milestone: -

tannergooding
tannergooding approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM.

Someone else should review and confirm the package/project settings are correct

@michaelgsharp
Copy link
Member Author

@tannergooding who would you recommend to review the project settings? Not sure who to ping.

@build-analysis build-analysis bot mentioned this pull request Aug 25, 2023
Closed
@danmoseley
Copy link
Member

@ViktorHofer perhaps

@michaelgsharp @ViktorHofer
Apply suggestions from code review
78bc22e 
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@build-analysis build-analysis bot mentioned this pull request Aug 25, 2023
Closed
@michaelgsharp michaelgsharp merged commit 2dfee0f into dotnet:main Aug 25, 2023
@michaelgsharp michaelgsharp deleted the bcl-numerics branch August 25, 2023 20:36
michaelgsharp added a commit to michaelgsharp/runtime that referenced this pull request Sep 18, 2023
@michaelgsharp @ViktorHofer
New Microsoft.BCL.Numerics package (dotnet#91074)
55726fa 
* bcl numberics library added

* bcl done

* added explicit 2.1 target

* Minor doc updates

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* fixes from PR comments

* minor csproj fixes

* fixed ref target frameworks

* minor ref csproj updates

* minor csproj updates

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ericstj pushed a commit that referenced this pull request Sep 19, 2023
@michaelgsharp @tannergooding
@ViktorHofer @stephentoub @tmds
[release/8.0] Numerics and Tensors backport (#92245)
4b7c754 
* added Bcl.Numerics

* Adding a naive implementation of various primitive tensor operations (#91228)

* Adding a naive implementation of various primitive tensor operations

* Adding tests covering the new tensor primitives APIs

* Adding tensor primitives APIs to the ref assembly

* Allow .NET Framework to build/run

* Sync TFMs between ref and src, csproj simplication and clean-up

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* Don't use var

* Fix the S.N.Tensors readme and remove the file marking it as non-shipping

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>

* Start vectorizing TensorPrimitives (#91596)

* Start vectorizing TensorPrimitives

Just does two functions to establish the files into which the rest of the implementations can be moved.

* 6 more naive methods for Tensor Primitives. (#92142)

* 6 more naive methods

* updates from pr comments

* Add remaining set of TensorPrimitives APIs for .NET 8 (#92154)

* Add remaining set of TensorPrimitives APIs for .NET 8

Adds non-vectorized implementations of:
- Max
- Min
- MaxMagnitude
- MinMagnitude
- IndexOfMax
- IndexOfMin
- IndexOfMaxMagnitude
- ConvertToHalf (only on .NET Core)
- ConvertToSingle (only on .NET Core)
- IndexOfMinMagnitude

Adds vectorized implementations of:
- Sum
- SumOfSquares
- SumOfMagnitudes
- Product
- ProductOfSums
- ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:
- Handling alignment better
- Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar

* Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests

* Address PR feedback, and fix a few other issues

* Fix TensorPrimitives.CosineSimilarity to use vectorized implementations (#92204)

* Fixed duplicated code from merge.

* New Microsoft.BCL.Numerics package (#91074)

* bcl numberics library added

* bcl done

* added explicit 2.1 target

* Minor doc updates

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* fixes from PR comments

* minor csproj fixes

* fixed ref target frameworks

* minor ref csproj updates

* minor csproj updates

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. (#91402)

* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource.

* Use NetCoreAppCurrent.

* Try fix CI test failures.

---------

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

@tannergooding tannergooding tannergooding approved these changes

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@michaelgsharp michaelgsharp

Labels
area-System.Numerics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michaelgsharp @danmoseley @huoyaoyuan @ViktorHofer @ericstj @tannergooding @teo-tsirpanis