Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] WBT tests failing when to compile aot-instances.dll.bc when using -O0 #93023

Closed
radical opened this issue Oct 4, 2023 · 2 comments
Closed
Labels
arch-wasm WebAssembly architecture area-Build-mono Known Build Error Use this to report build issues in the .NET Helix tab test-failure

Comments

@radical
Copy link
Member

radical commented Oct 4, 2023

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=427185
Build error leg or test failing: Wasm.Build.Tests.SatelliteAssembliesTests.CheckThatSatelliteAssembliesAreNotAOTed(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = True, ProjectFileContents = placeholder, ExtraBuildArgs = }, id: "kbid5vmh_0lm")
Pull request: #93001

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "aot-instances.dll.bc.*returned 137",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=427185
Error message validated: aot-instances.dll.bc.*returned 137
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/4/2023 7:07:10 PM UTC

@radical radical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Oct 4, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 4, 2023
@radical radical added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=427185
Build error leg or test failing: Wasm.Build.Tests.SatelliteAssembliesTests.CheckThatSatelliteAssembliesAreNotAOTed(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = True, ProjectFileContents = placeholder, ExtraBuildArgs = }, id: "kbid5vmh_0lm")
Pull request: #93001

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "aot-instances.dll.bc.*returned 137",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-Build-mono, Known Build Error

Milestone: -

radical added a commit to radical/runtime that referenced this issue Oct 4, 2023
Some WBT tests started failing while compiling `aot-instances.dll.bc`
when compiled with `-O0`. So, we avoid using that where possible.

Issue: dotnet#93023
lewing pushed a commit that referenced this issue Oct 5, 2023
* [wasm] WBT: Avoid using `-O0` in tests

Some WBT tests started failing while compiling `aot-instances.dll.bc`
when compiled with `-O0`. So, we avoid using that where possible.

Issue: #93023

* SatelliteAssembliesTests.CheckThatSatelliteAssembliesAreNotAOTed: Use -O1

Using `WasmDedup=false` avoided `aot-instances.dll.bc`, but then still
using `-O0` caused System.Private.CoreLib.dll.bc to fail.
@radical
Copy link
Member Author

radical commented Oct 5, 2023

Fixed by #93026 .

@radical radical closed this as completed Oct 5, 2023
@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Oct 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Known Build Error Use this to report build issues in the .NET Helix tab test-failure
Projects
None yet
Development

No branches or pull requests

1 participant