Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][WBT] SatelliteLoadingTests.LoadSatelliteAssembly - ActiveIssue #93387

Closed
pavelsavara opened this issue Oct 12, 2023 · 3 comments
Closed

[browser][WBT] SatelliteLoadingTests.LoadSatelliteAssembly - ActiveIssue #93387

pavelsavara opened this issue Oct 12, 2023 · 3 comments
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Oct 12, 2023 •
edited
Loading

Unit test LoadSatelliteAssembly is sensitive to bug of duplicate result marshaling which was fixed in #92403

This active issue could be removed from code and closed after the fix flows into WBT

Log

System.Xml.ReaderWriter.wasm: Object, System.Xml.XmlDocument.wasm: Object, System.Xml.XmlSerializer.wasm: Object, System.Xml.wasm: Object, System.wasm: Object, WindowsBase.wasm: Object, mscorlib.wasm: Object, netstandard.wasm: Object, WasmBasicTestApp.wasm: Object, System.Private.CoreLib.wasm: Object}
        [endGroup] console.groupEnd
        [endGroup] console.groupEnd
        [log] TestOutput -> default: hello
        [log] TestOutput -> es-ES without satellite: hello
        [log] TestOutput -> default: hello
        [log] TestOutput -> es-ES with satellite: hola
        [info] WASM EXIT 1
============== DELETING THE BUILDS =============
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Oct 12, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 12, 2023
@ghost
Copy link

ghost commented Oct 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Unit test LoadSatelliteAssembly is sensitive to bug of duplicate result marshaling which was fixed in #92403

This active issue could be removed from code and closed after the fix flows into WBT

Author: pavelsavara
Assignees: radical
Labels:

arch-wasm, area-Build-mono, os-browser
Milestone: 9.0.0

radical added a commit to radical/runtime that referenced this issue Oct 16, 2023
@radical
Workloads test: Install the current app.ref pack also
01501ff 
Re-enable updating the targeting pack as the workload is correctly using
9.0 artifacts. The targeting pack update is needed because it includes
the locally built analyzers, like the source generators for
`JSImport/Export`.

This fixes `SatelliteLoadingTests.LoadSatelliteAssembly`.

Fixes issue: dotnet#93387
@radical radical mentioned this issue Oct 16, 2023
Closed
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Oct 16, 2023
@lewing
Copy link
Member

lewing commented Oct 18, 2023

fixed in #93625

@lewing lewing closed this as completed Oct 18, 2023
@lewing
Copy link
Member

lewing commented Oct 18, 2023

Oh I should probably remove the active issue

@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Workloads test: Install the current app.ref pack also radical/runtime
3 participants
@radical @lewing @pavelsavara