Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and unify debug views of immutable dictionaries #94289

Closed
eiriktsarpalis opened this issue Nov 2, 2023 · 1 comment · Fixed by #100745
Closed

Improve and unify debug views of immutable dictionaries #94289

eiriktsarpalis opened this issue Nov 2, 2023 · 1 comment · Fixed by #100745
Labels
area-System.Collections enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Nov 2, 2023 •
edited
Loading

Almost forgot, but would it be possible to include this change in immutable collections as well? If you prefer to do this in a future PR that's also fine.

It's on my list. I'd prefer to do it in a separate PR just to close this phase and keep scope of this PR smaller.

Originally posted by @arturek in #92534 (comment)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 2, 2023
@ghost
Copy link

ghost commented Nov 2, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details 
          @eiriktsarpalis

Almost forgot, but would it be possible to include this change in immutable collections as well? If you prefer to do this in a future PR that's also fine.

It's on my list. I'd prefer to do it in a separate PR just to close this phase and keep scope of this PR smaller.

Originally posted by @arturek in #92534 (comment)

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Collections
Milestone: -

@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Nov 2, 2023
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Nov 2, 2023
@eiriktsarpalis eiriktsarpalis added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 2, 2023
arturek added a commit to arturek/runtime that referenced this issue Nov 9, 2023
@arturek
Fix ReadOnlyDictionary and improve DebuggerAttributes
4b8524d 
* Fix debugger type proxy attributes for Key and Value collections of ReadOnlyDictionary
* Separate methods to test validity of the DebuggerTypeProxy attribute
  * ValidateDebuggerTypeProxyProperties - to verify debugger type proxy in most cases
  * CreateDebuggerTypeProxyWithNullArgument - to verify that the constructor of the debugger type proxy throws when its argument is null.
* Simplify and make more uniform debugger type proxy tests

A prerequisite for dotnet#94289
@arturek arturek mentioned this issue Nov 9, 2023
Merged
eiriktsarpalis added a commit that referenced this issue Jan 26, 2024
@arturek @eiriktsarpalis
Fix ReadOnlyDictionary and improve DebuggerAttributes (#94581)
bcc1d3d 
* Fix ReadOnlyDictionary and improve DebuggerAttributes

* Fix debugger type proxy attributes for Key and Value collections of ReadOnlyDictionary
* Separate methods to test validity of the DebuggerTypeProxy attribute
  * ValidateDebuggerTypeProxyProperties - to verify debugger type proxy in most cases
  * CreateDebuggerTypeProxyWithNullArgument - to verify that the constructor of the debugger type proxy throws when its argument is null.
* Simplify and make more uniform debugger type proxy tests

A prerequisite for #94289

* Include ReadOnlyDictionary's Keys and Values in shared tests of debugger attributes

* Excuded some test cases because of bugs in .Net Framework 4.8

---------

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
arturek added a commit to arturek/runtime that referenced this issue Apr 7, 2024
@arturek
Unify debug views of immutable dictionaries
528aeea 
Fixes dotnet#94289

- Updates the way the debugger displays the remaining dictionaries (Frozen, Immutable, ImmutableSorted, Concurrent) to present their keys and values in separate columns.
- Fixes debugger views of Builder classes of immutable collections. Previous custom implementations incorrectly treated the Builder classes as immutable.
@arturek arturek mentioned this issue Apr 7, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Apr 7, 2024
eiriktsarpalis pushed a commit to arturek/runtime that referenced this issue Jun 24, 2024
@arturek @eiriktsarpalis
Unify debug views of immutable dictionaries
5617c57 
Fixes dotnet#94289

- Updates the way the debugger displays the remaining dictionaries (Frozen, Immutable, ImmutableSorted, Concurrent) to present their keys and values in separate columns.
- Fixes debugger views of Builder classes of immutable collections. Previous custom implementations incorrectly treated the Builder classes as immutable.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Collections enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Unify debug views of immutable dictionaries arturek/runtime
1 participant
@eiriktsarpalis