Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify functionality GenerateReferenceAssemblySource and GenerateReferenceSource #948

Closed
ericstj opened this issue Dec 11, 2018 · 1 comment · Fixed by #35818
Closed

Unify functionality GenerateReferenceAssemblySource and GenerateReferenceSource #948

ericstj opened this issue Dec 11, 2018 · 1 comment · Fixed by #35818
Assignees
@ViktorHofer @ericstj
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Milestone
Future

Comments

@ericstj
Copy link
Member

ericstj commented Dec 11, 2018

GenAPI defines GenerateReferenceAssemblySource https://github.com/dotnet/arcade/blob/55c0d49b9bec66981f7dd6d8f51a8dad43e8fbe0/src/Microsoft.DotNet.GenAPI/build/Microsoft.DotNet.GenAPI.targets#L31-L47, but we don't use it in CoreFx.

Instead we use GenerateReferenceSource https://github.com/dotnet/corefx/blob/4a84b8798dbd861675014b420e4c01f6a2116125/Directory.Build.targets#L176-L195.

We should delete GenerateReferenceSource and make sure that GenerateReferenceAssemblySource can handle our scenarios, then update the docs to to use it (eg: by setting the property).

/cc @wtgodbe
@ericstj ericstj self-assigned this Apr 3, 2019
@ericstj
Copy link
Member Author

ericstj commented Apr 3, 2019

Make sure we address dotnet/corefx#31193 when doing this.

@maryamariyan maryamariyan transferred this issue from dotnet/corefx Dec 16, 2019
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Dec 16, 2019
@maryamariyan maryamariyan added this to the Future milestone Dec 16, 2019
@Anipik Anipik mentioned this issue May 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

@ericstj ericstj

Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Use already defined generateAssemblyReferenceSource rather defining a new target
4 participants
@maryamariyan @ViktorHofer @ericstj @Dotnet-GitSync-Bot