-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use already defined generateAssemblyReferenceSource rather defining a new target #35818
Conversation
Tagging subscribers to this area: @ViktorHofer |
|
should wait until this dotnet/arcade#5419 is avaliable in runtime |
I don't want to be over-aggressive with the batched rollout but you are renaming a target that devs are used to. That's a candidate for the next batched rollout: #35895. |
You can keep the old target and just have it depend on the new one. If you want to be cute you could emit a warning in the old target about deprecation. Then delete the old one in next batched rollout. |
I like cute. |
I like this idea to not block until next batch rollout. |
i added the target back to unblock this and also updated the genapi version. I have tested the change locally and both the targets work |
Fixes #948
Fixes #34604