Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove repo zip + unzip steps from CI bulds #96

Closed
mmitche opened this issue Nov 18, 2019 · 6 comments
Closed

Remove repo zip + unzip steps from CI bulds #96

mmitche opened this issue Nov 18, 2019 · 6 comments
Labels
area-Infrastructure-coreclr
Milestone
6.0.0

Comments

@mmitche
Copy link
Member

mmitche commented Nov 18, 2019

https://dev.azure.com/dnceng/public/_build/results?buildId=430659&view=logs&j=9269f66d-1f85-5c3b-5cd1-c24f22859cb8

I believe this was added to workaround the throttling that was happening when building coreclr. Since this got fixed via a network reconfiguration on the GitHub side, this can probably be removed.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Nov 18, 2019
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Nov 18, 2019
@ViktorHofer ViktorHofer added this to the 5.0 milestone Nov 18, 2019
@ViktorHofer
Copy link
Member

cc @trylek @jashook @jkoritzinsky

@jkoritzinsky
Copy link
Member

The repo zip/unzip steps have also enabled the coreclr builds to all use the same merge commit. We were having issues beforehand where the product build would use one commit and the test would use a later one if someone merged a PR in the middle, sometimes leading to confusing extraneous test failures.

@trylek
Copy link
Member

trylek commented Nov 18, 2019

I also believe @echesakovMSFT has a working change about to port to the runtime repo that further improves on this logic by replacing zipping / unzipping with git bundles which should be cleaner and remove the need for two different checkouts on Windows / Linux.

@mmitche
Copy link
Member Author

mmitche commented Nov 18, 2019

The repo zip/unzip steps have also enabled the coreclr builds to all use the same merge commit. We were having issues beforehand where the product build would use one commit and the test would use a later one if someone merged a PR in the middle, sometimes leading to confusing extraneous test failures.

That should not happen and is a bug in AzDO if it does. Assuming that they are being run in the same pipeline, the specific merge sha should be being passed around. If that is not the case, then that is a serious bug that we should not workaround.

We should really get rid of this workaround.

@trylek
Copy link
Member

trylek commented Nov 18, 2019

OK, if you say this should now work correctly and throttling is no longer a problem, I can easily prepare and test a change to remove the repo zipping / unzipping.

@trylek trylek mentioned this issue Nov 18, 2019
Closed
@trylek trylek mentioned this issue Jan 22, 2020
Closed
@briansull briansull mentioned this issue Jan 30, 2020
Closed
@jashook jashook modified the milestones: 5.0.0, 6.0.0 Aug 3, 2020
@hoyosjs
Copy link
Member

hoyosjs commented Jul 21, 2021

We no longer do this.

@hoyosjs hoyosjs closed this as completed Jul 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
radical pushed a commit to radical/runtime that referenced this issue Jul 7, 2022
@premun
[iOS] Refactor AppRunner (dotnet#224)
8f6cc04 
This PR fixes dotnet#196 and refactors the AppRunner formerly from Xamarin to enable better logging, easier debugging, fixes some small bugs and splits large methods.

- Refactor `AppRunner`
  - Split very long methods by Device/Simulator bound logic
  - Separate logic for test orchestration with mlaunch argument preparation
  - Dispose logs/listeners correctly
  - Look for devices before we start the listeners and log capturers
  - Improved unit test readability where the most important part (mlaunch arg checking) is now easier to read and safe to make changes when logic changes
- Improve finding simulators:
  - Enable nullability for `BlockingEnumerable`, `SimulatorLoader` and connected POCO classes
  - Improve error messages
  - Make `SimulatorLoader` retry listing devices as that might fail occasionally
  - Make it more clear that `SimulatorLoader` only looks for device tuples `(simulator, companion)` and not all simulators on the MacOS
- Log exit codes

Fixes: dotnet#96
Fixes: dotnet#196
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove git bundle logic and restore the original per-job checkout trylek/runtime
7 participants
@jkoritzinsky @jashook @ViktorHofer @mmitche @trylek @hoyosjs @Dotnet-GitSync-Bot