-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeName parsing API #100094
TypeName parsing API #100094
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 22d131e - Browse repository at this point
Copy the full SHA 22d131eView commit details
Commits on Jan 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5de9526 - Browse repository at this point
Copy the full SHA 5de9526View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6dbcd59 - Browse repository at this point
Copy the full SHA 6dbcd59View commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f1f161 - Browse repository at this point
Copy the full SHA 6f1f161View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ec4ea5 - Browse repository at this point
Copy the full SHA 4ec4ea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a8716 - Browse repository at this point
Copy the full SHA f5a8716View commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 52cb351 - Browse repository at this point
Copy the full SHA 52cb351View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60ad6f0 - Browse repository at this point
Copy the full SHA 60ad6f0View commit details -
integrate with System.Private.CoreLib:
- allow ignoring errors (return null) - assembly name parsing
Configuration menu - View commit details
-
Copy full SHA for b5349bd - Browse repository at this point
Copy the full SHA b5349bdView commit details
Commits on Feb 1, 2024
-
integrate with System.Private.CoreLib:
- report errorIndex in the ex message - fix Full Framework build - fix nested types support - implement NativeAOT part
Configuration menu - View commit details
-
Copy full SHA for 2dbd091 - Browse repository at this point
Copy the full SHA 2dbd091View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd78637 - Browse repository at this point
Copy the full SHA bd78637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fda94a - Browse repository at this point
Copy the full SHA 8fda94aView commit details
Commits on Feb 7, 2024
-
make TypeNameParser internal, extend TypeName with Parse and TryParse…
… methods, move "allowFullyQualifiedName" to Options bag
Configuration menu - View commit details
-
Copy full SHA for 745e7bb - Browse repository at this point
Copy the full SHA 745e7bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee43e71 - Browse repository at this point
Copy the full SHA ee43e71View commit details
Commits on Feb 8, 2024
-
introduce FullName, so we have Name, FullName and AssemblyQualifiedNa…
…me and they are consistent with Sytem.Type APIs
Configuration menu - View commit details
-
Copy full SHA for a3a7f26 - Browse repository at this point
Copy the full SHA a3a7f26View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2296d0 - Browse repository at this point
Copy the full SHA a2296d0View commit details -
move helper methods to a standalone helper type, include it as a link…
… in test project and cover with tests, fix edge case bugs
Configuration menu - View commit details
-
Copy full SHA for 4c8a6f7 - Browse repository at this point
Copy the full SHA 4c8a6f7View commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eadf970 - Browse repository at this point
Copy the full SHA eadf970View commit details -
Configuration menu - View commit details
-
Copy full SHA for abf7543 - Browse repository at this point
Copy the full SHA abf7543View commit details
Commits on Feb 13, 2024
-
cover more serialization binder scenarios with the tests to ensure th…
…e API is complete
Configuration menu - View commit details
-
Copy full SHA for 281c4f3 - Browse repository at this point
Copy the full SHA 281c4f3View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dc58cce - Browse repository at this point
Copy the full SHA dc58cceView commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b947977 - Browse repository at this point
Copy the full SHA b947977View commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c9a7d5 - Browse repository at this point
Copy the full SHA 4c9a7d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c63f3a8 - Browse repository at this point
Copy the full SHA c63f3a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83cdd1b - Browse repository at this point
Copy the full SHA 83cdd1bView commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23ad44f - Browse repository at this point
Copy the full SHA 23ad44fView commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96b04f4 - Browse repository at this point
Copy the full SHA 96b04f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8014fd - Browse repository at this point
Copy the full SHA c8014fdView commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c76366 - Browse repository at this point
Copy the full SHA 1c76366View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cd205a - Browse repository at this point
Copy the full SHA 8cd205aView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae514ec - Browse repository at this point
Copy the full SHA ae514ecView commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7c67c8 - Browse repository at this point
Copy the full SHA c7c67c8View commit details -
Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 87804e9 - Browse repository at this point
Copy the full SHA 87804e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97aad27 - Browse repository at this point
Copy the full SHA 97aad27View commit details -
remove everything related to strict parsing (it will come back in a s…
…imilar form but with a different name)
Configuration menu - View commit details
-
Copy full SHA for f940723 - Browse repository at this point
Copy the full SHA f940723View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ed250 - Browse repository at this point
Copy the full SHA b1ed250View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90a5582 - Browse repository at this point
Copy the full SHA 90a5582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5d01b - Browse repository at this point
Copy the full SHA 9a5d01bView commit details
Commits on Apr 3, 2024
-
don't pre-allocate full names for all declaring types, just store the…
… full name of final type and the length of the substring
Configuration menu - View commit details
-
Copy full SHA for cfb2216 - Browse repository at this point
Copy the full SHA cfb2216View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63365f - Browse repository at this point
Copy the full SHA d63365fView commit details
Commits on Apr 9, 2024
-
Merge remote-tracking branch 'upstream/main' into typeNameParser
# Conflicts: # src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Configuration menu - View commit details
-
Copy full SHA for 7d685c8 - Browse repository at this point
Copy the full SHA 7d685c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04731fb - Browse repository at this point
Copy the full SHA 04731fbView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 113a87f - Browse repository at this point
Copy the full SHA 113a87fView commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7005164 - Browse repository at this point
Copy the full SHA 7005164View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd8a9c2 - Browse repository at this point
Copy the full SHA cd8a9c2View commit details
Commits on Apr 17, 2024
-
Merge remote-tracking branch 'upstream/main' into typeNameParser
# Conflicts: # src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Configuration menu - View commit details
-
Copy full SHA for 1143a3e - Browse repository at this point
Copy the full SHA 1143a3eView commit details -
address API and code review feedback:
- remove IEquatable Implementation from TypeName and AssemblyNameInfo (and GetHashCode too) - parser should not enforce runtime-specific rules like illegal type decorators (ByRef to ByRef etc) - add XML docs for the new AssemblyNameInfo type - propagate ProcessorArchitecture and ContentType from AssemblyNameInfo to the created AssemblyName - reject PublicKeyToken of odd length - remove checked arithmetic for getting node count: it's impossible to parse a name that would cause int overflow - add test case for escaped closing square bracket in the assembly name - remove unused code - address TODOs - add clarifications for ECMA divergence - remove one step from AssemblyNameInfo -> AssemblyName -> RuntimeAssemblyName conversion for NativeAOT
Configuration menu - View commit details
-
Copy full SHA for afdbc5f - Browse repository at this point
Copy the full SHA afdbc5fView commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 413be9e - Browse repository at this point
Copy the full SHA 413be9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b424d76 - Browse repository at this point
Copy the full SHA b424d76View commit details
Commits on Apr 23, 2024
-
- unify syntax for character checks - remove false statement about unreachable code from the AssemblyNameParser - fix whitespace formatting - reduce code duplication and supress RS0030 for TypeSystem (we need to use System.Linq.ImmutableArrayExtensions.ToArray) - use hungarian notation for static fields - remove boxing - pass VSB by reference to avoid resource leaks - use HexConverter.TryDecodeFromUtf16
Configuration menu - View commit details
-
Copy full SHA for da203c0 - Browse repository at this point
Copy the full SHA da203c0View commit details
Commits on Apr 24, 2024
-
- don't throw TypeLoadException in the parser, let loader do that - add Debug.Assert(typeName.IsSimple) for clarity - always include invalid character index in the error message - remove resources added to CoreLib (they are never going to be used) - use [DoesNotReturn] and implement proper throw helper pattern - remove outdated comment about name validation - AssemblyNameInfo.Flags should return the exact value provided in ctor - don't allocate FullName until it's really needed - refactor Make and Resovle methods into one method - fix the test: specify namespace to make sure the type loader loads System.Int32 and later throws TypeLoadException for byref to byref
Configuration menu - View commit details
-
Copy full SHA for 7979e27 - Browse repository at this point
Copy the full SHA 7979e27View commit details -
Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 22de761 - Browse repository at this point
Copy the full SHA 22de761View commit details