Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeAnalysis config to include recently-added rules #100146

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

stephentoub
Copy link
Member

No description provided.

@stephentoub stephentoub requested a review from buyaa-n March 22, 2024 14:53
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 22, 2024
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephentoub stephentoub force-pushed the updateanalysis branch 2 times, most recently from acb4d11 to e9f454c Compare March 25, 2024 02:10
@kg
Copy link
Member

kg commented Apr 3, 2024

This made WASM startup faster, thanks @stephentoub :)

@stephentoub
Copy link
Member Author

This made WASM startup faster, thanks @stephentoub :)

Interesting. That's a nice side effect, though it wasn't the primary intent :) Do you know why it got faster? Only explanation I could think of were some of the string-to-char changes could have resulted possibly in globalization code not being needed until later?

@kg
Copy link
Member

kg commented Apr 3, 2024

There was a search for "." instead of '.' that was fully loading in ICU during startup.

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants