Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special casing System.Guid for COM VARIANT marshalling #100377

Merged
merged 11 commits into from
Apr 5, 2024
Merged

Special casing System.Guid for COM VARIANT marshalling #100377

merged 11 commits into from
Apr 5, 2024

Commits on Mar 27, 2024

  1. Support System.Guid marshalling via VARIANT 

    VARIANT marshalling in .NET 5+ requires a TLB
for COM records (i.e., ValueType instances). This
means that without a runtime provided TLB, users
must define their own TLB for runtime types or
define their own transfer types.

We address this here by deferring to the NetFX
mscorlib's TLB.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    983da44 View commit details
    Browse the repository at this point in the history

  2. Add marshalling of System.Guid in the other direction.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9fabe55 View commit details
    Browse the repository at this point in the history

  3. Adding testing for COM VARIANT marshalling

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b7bd556 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Fix contract

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c85557f View commit details
    Browse the repository at this point in the history

  2. Fix libraries tests

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bf2bb94 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @AaronRobinsonMSFT @elinor-fung
    AaronRobinsonMSFT and elinor-fung authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    29ce8d0 View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7e26867 View commit details
    Browse the repository at this point in the history

  3. Add Guid test for GetObjectForNativeVariant()

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ee4d6bb View commit details
    Browse the repository at this point in the history

  4. Handle the Nano server case.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    215b581 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Add test for dynamic scenarios

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b092250 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @AaronRobinsonMSFT @elinor-fung
    AaronRobinsonMSFT and elinor-fung authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ecd9e47 View commit details
    Browse the repository at this point in the history