Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] fix error propagation when calling JSImport of missing JS function #100408

Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 28, 2024

Bug introduced in #100233
Will solve timeouts of System.Runtime.InteropServices.JavaScript.Tests.JSImportTest.MissingImport in #99888

  • fixed the error propagation
  • added another test

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Mar 28, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 28, 2024
@pavelsavara pavelsavara requested a review from maraf March 28, 2024 14:09
@pavelsavara pavelsavara self-assigned this Mar 28, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara requested a review from mkhamoyan March 28, 2024 14:11
@pavelsavara pavelsavara marked this pull request as ready for review March 28, 2024 14:12
@pavelsavara pavelsavara requested a review from lewing as a code owner March 28, 2024 14:12
@pavelsavara
Copy link
Member Author

/ba-g CI failures are known #100388

@pavelsavara pavelsavara merged commit 93483ba into dotnet:main Apr 2, 2024
95 of 98 checks passed
@pavelsavara pavelsavara deleted the browser_mt_missing_async_import branch April 2, 2024 17:50
jakobbotsch pushed a commit to jakobbotsch/runtime that referenced this pull request Apr 3, 2024
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants