Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize flips between 1 and 0 #100491

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Optimize flips between 1 and 0 #100491

merged 1 commit into from
Apr 30, 2024

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Apr 1, 2024

We can solve this with a bit flip rather than + 1 mod 2.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 1, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 1, 2024
@AreaZR
Optimize flips between 1 and 0
252369b 
We can solve this with a bit flip rather than + 1 mod 2.
@JulieLeeMSFT
Copy link
Member

@kunalspathak PTAL.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Apr 30, 2024
@am11
Copy link
Member

am11 commented Apr 30, 2024

Speaking of 1's complement, bool M(bool boolean) => !boolean can use movzx+not instead of xor+test+sete on xarch.

@kunalspathak
Copy link
Member

/azp runtime-coreclr superpmi-diffs

@azure-pipelines Azure Pipelines
Copy link

Command 'runtime-coreclr' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@kunalspathak
Copy link
Member

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kunalspathak
kunalspathak approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 333fb71 into dotnet:main Apr 30, 2024
111 of 117 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@AreaZR @matouskozak
Optimize flips between 1 and 0 (dotnet#100491)
5b45b35 
We can solve this with a bit flip rather than + 1 mod 2.
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@AreaZR @michaelgsharp
Optimize flips between 1 and 0 (dotnet#100491)
c59922b 
We can solve this with a bit flip rather than + 1 mod 2.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@AreaZR @Ruihan-Yin
Optimize flips between 1 and 0 (dotnet#100491)
6008f75 
We can solve this with a bit flip rather than + 1 mod 2.
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AreaZR @JulieLeeMSFT @am11 @kunalspathak