Make host tests use single copy of shared framework #100588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
This was referenced Apr 3, 2024
AaronRobinsonMSFT
approved these changes
Apr 4, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
- Only create one .NET install layout to be shared by all host tests - Add `pretest.proj` for `host.pretest` subset that builds all test project assets and creates the single .NET install layout - Fix `NativeHostApis` tests that were editing the .NET install layout directly (instead of creating a copy to edit) - Remove some unnecessary copying/creating of SDKs and frameworks by sharing the fixture across tests - Update host testing doc with simpler setup instructions and more details around investigating test failures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit some more test oddities while looking at #99027, so:
host.pretestsubsetpretest.projthat builds all test project assets and creates the single .NET install layoutNativeHostApistestscc @vitek-karas