Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] cdac-build-tool #100650

Merged
merged 67 commits into from
Apr 19, 2024
Merged

[cdac] cdac-build-tool #100650

merged 67 commits into from
Apr 19, 2024

Commits on Apr 4, 2024

  1. checkpoint

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8518e9f View commit details
    Browse the repository at this point in the history

  2. add old tooling notes

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    12aef6d View commit details
    Browse the repository at this point in the history

  3. add an emitter

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1eff4d0 View commit details
    Browse the repository at this point in the history

  4. checkpoint read in the directory header

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    22e217b View commit details
    Browse the repository at this point in the history

  5. checkpoint plausible-looking offsets

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    dd9279d View commit details
    Browse the repository at this point in the history

  6. checkpoint: field stuff is working

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    492af29 View commit details
    Browse the repository at this point in the history

  7. checkpoint json

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    459d124 View commit details
    Browse the repository at this point in the history

  8. contract parsing

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    28f8256 View commit details
    Browse the repository at this point in the history

  9. refactor

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    418739d View commit details
    Browse the repository at this point in the history

  10. indirect pointer value support

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1c1524d View commit details
    Browse the repository at this point in the history

  11. move sample to tool dir

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    34e852e View commit details
    Browse the repository at this point in the history

  12. Take baselines from the docs/design/datacontracts/data dir 

    We don't parse them yet, however
    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e48e709 View commit details
    Browse the repository at this point in the history

  13. Add README

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0e8c60e View commit details
    Browse the repository at this point in the history

  14. fix BE 

    Store the magic as a uint64_t so that it will follow the platform
endianness.

Store endmagic as bytes so that it directly follows the name pool -
and fix the endmagic check not to look at the endianness
    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cd4f0f0 View commit details
    Browse the repository at this point in the history

  15. hook up cdac-build-tool to the coreclr build; export DotNetRuntimeCon… 

    …tractDescriptor
    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b6b079e View commit details
    Browse the repository at this point in the history

  16. try fix win-x86 build warning

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a9b0d7f View commit details
    Browse the repository at this point in the history

  17. paths

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    dbf0557 View commit details
    Browse the repository at this point in the history

  18. vebose

    @lambdageek
    lambdageek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    74433f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. fix typo; fixes win32

    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ea441b6 View commit details
    Browse the repository at this point in the history

  2. cleanup; add contracts.txt

    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    787b836 View commit details
    Browse the repository at this point in the history

  3. add diagram to README

    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e015e83 View commit details
    Browse the repository at this point in the history

  4. move implementation notes

    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0354723 View commit details
    Browse the repository at this point in the history

  5. better verbose output from ObjectFileScraper

    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    da038f3 View commit details
    Browse the repository at this point in the history

  6. turn off whole program optimizations for data-descriptor.obj 

    On windows /GL creates object files that cdac-build-tool cannot read

It's ok to do this because we don't ship data-descriptor.obj as part
of the product - it's only used to generate the cDAC descriptor
    @lambdageek
    lambdageek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f64b548 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. C++-ify and add real Thread offsets

    @lambdageek
    lambdageek committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2e29a10 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. no C99 designated initializers in C++ until C++20

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    58162a3 View commit details
    Browse the repository at this point in the history

  2. build data descriptor after core runtime

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4bb51bf View commit details
    Browse the repository at this point in the history

  3. fix gcc build

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9700e29 View commit details
    Browse the repository at this point in the history

  4. fix typo

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3f22c7c View commit details
    Browse the repository at this point in the history

  5. simplify ObjectFileScraper 

    just read the whole file into memory
    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4aae511 View commit details
    Browse the repository at this point in the history

  6. more dependencies

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    60738ef View commit details
    Browse the repository at this point in the history

  7. try fix source build

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c0dab90 View commit details
    Browse the repository at this point in the history

  8. remove fixme; document

    @lambdageek
    lambdageek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    84eaa3b View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Merge commit 'origin/main^' into cdac-contract-tool

    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    86e5258 View commit details
    Browse the repository at this point in the history

  2. invoke 'dotnet cmake-build-tool.dll' instead of 'dotnet run --project'

    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cc658c9 View commit details
    Browse the repository at this point in the history

  3. clean up macro boilerplate

    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    39fe70d View commit details
    Browse the repository at this point in the history

  4. platform flags

    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5064deb View commit details
    Browse the repository at this point in the history

  5. turn off verbose output

    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    74000bc View commit details
    Browse the repository at this point in the history

  6. can't use constexpr function in coreclr 

    because debugreturn.h defines a `return` macro that expands to
something that is not c++11 constexpr
    @lambdageek
    lambdageek committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    76c27bc View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Code review fixups 

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    270fe21 View commit details
    Browse the repository at this point in the history

  2. Rename "aux data" to "pointer data"

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    84e0800 View commit details
    Browse the repository at this point in the history

  3. rename "data-descriptor" to "datadescriptor"

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    51da4e3 View commit details
    Browse the repository at this point in the history

  4. simplify linking

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b26f3ac View commit details
    Browse the repository at this point in the history

  5. cdac-build-tool don't build dotnet tool; turn on analyzers

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8f9d1a7 View commit details
    Browse the repository at this point in the history

  6. update README

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    87b79b3 View commit details
    Browse the repository at this point in the history

  7. rationalize naming; update docs; add some inline comments

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b33ad07 View commit details
    Browse the repository at this point in the history

  8. rm whitespace 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @lambdageek @AaronRobinsonMSFT
    lambdageek and AaronRobinsonMSFT authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c39e6f4 View commit details
    Browse the repository at this point in the history

  9. renamce cdac.h to cdacoffsets.h

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5ef8428 View commit details
    Browse the repository at this point in the history

  10. comments

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9f381be View commit details
    Browse the repository at this point in the history

  11. fixup README

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    443f83b View commit details
    Browse the repository at this point in the history

  12. hex offsets; improved formatting

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9fc2b26 View commit details
    Browse the repository at this point in the history

  13. don't throw in ParseContracts; add line numbers to errors

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    024c566 View commit details
    Browse the repository at this point in the history

  14. spelling

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b0f1f40 View commit details
    Browse the repository at this point in the history

  15. Update README.md

    @lambdageek
    lambdageek authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2852d8d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. change input format for contracts to jsonc

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2429bd8 View commit details
    Browse the repository at this point in the history

  2. add custom JsonConverter instances for the compact json representation

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    18a863e View commit details
    Browse the repository at this point in the history

  3. code review changes

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a49e5e6 View commit details
    Browse the repository at this point in the history

  4. inline comments into the data-descriptor-blob C code

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1f5ba44 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2decea4 View commit details
    Browse the repository at this point in the history

  6. comments and markdown

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ce18bee View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e143998 View commit details
    Browse the repository at this point in the history

  2. simplify; bug fix - PointerDataCount include placeholder

    @lambdageek
    lambdageek committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    08cf75d View commit details
    Browse the repository at this point in the history

  3. fixup docs

    @lambdageek
    lambdageek committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0d4d40d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-contract-tool

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    94c56ea View commit details
    Browse the repository at this point in the history

  2. Update src/coreclr/tools/cdac-build-tool/JsonConverter/GlobalModelJso… 

    …nConverter.cs

Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3d49b70 View commit details
    Browse the repository at this point in the history

  3. one more set of feedback changes

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f845c41 View commit details
    Browse the repository at this point in the history

  4. maybe no live ILLink ?

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    64430cf View commit details
    Browse the repository at this point in the history