RSABCrypt: Improve errors with public key only #100658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Apr 5, 2024
vcsjones
changed the title
3 tasks
bartonjs
reviewed
Apr 5, 2024
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/RSABCrypt.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Apr 5, 2024
|
@dtivel I can't speak for backporting or not, but I opened NuGet/Home#13375 separately from this as a proposal for how NuGet can better handle this scenario. Even with this change, nuget users are going to get exceptions. |
It makes some errors more clear, but doesn't change the overall execution flow, so I don't think it would meet an LTS servicing bar. There'd have to be a clear improvement from it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RSABcrypt attempted to do a private operation when only possessing a public key, a CryptographicException with the message "Unknown error (0xc100000d)" was thrown. This PR changes it to throw a more helpful error when a private key is missing.
Fixes #100414