[browser][MT] faster memory view refresh + cleanup #101249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Apr 18, 2024
ilonatommy
approved these changes
Apr 19, 2024
| const memory = runtimeHelpers.getMemory(); | ||
| if (memory.buffer !== Module.HEAPU8.buffer) { | ||
| const wasmMemory = runtimeHelpers.getMemory(); | ||
| if (wasmMemory.buffer !== Module.HEAPU8.buffer) { |
There was a problem hiding this comment.
What's the reason of using updateMemoryViewes here, not forceThreadMemoryViewRefresh that differ with calling wasmMemory.grow(0);? We don't need to propagate the knowledge about the update between threads?
There was a problem hiding this comment.
I assume that grow(0) is relatively expensive.
But the receiveWorkerHeapViews is called from too many places.
maraf
approved these changes
Apr 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (wasmMemory.buffer !== Module.HEAPU8.buffer)toforceThreadMemoryViewRefreshif (WasmEnableThreads)There is sibling PR for testing what would happen if we remove it all #101248