-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SocketsHttpHandlerTest_HttpClientHandlerTest_Http3.ReadAsStreamAsync_Cancellation data race #101428
Merged
rzikm
merged 2 commits into
dotnet:main
from
rzikm:h3-cancellation-tests-handle-cancellation-exception
Apr 23, 2024
Merged
Fix SocketsHttpHandlerTest_HttpClientHandlerTest_Http3.ReadAsStreamAsync_Cancellation data race #101428
rzikm
merged 2 commits into
dotnet:main
from
rzikm:h3-cancellation-tests-handle-cancellation-exception
Apr 23, 2024
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzikm
force-pushed
the
h3-cancellation-tests-handle-cancellation-exception
branch
from
April 23, 2024 13:17
ac1f96f
to
0ade6f8
Compare
Tagging subscribers to this area: @dotnet/ncl |
rzikm
force-pushed
the
h3-cancellation-tests-handle-cancellation-exception
branch
from
April 23, 2024 13:19
0ade6f8
to
391384e
Compare
Loading status checks…
…ync_Cancellation data race
rzikm
force-pushed
the
h3-cancellation-tests-handle-cancellation-exception
branch
from
April 23, 2024 13:20
391384e
to
7900958
Compare
This was referenced Apr 23, 2024
ManickaP
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
Closed
Other test failures are unrelated |
This was referenced Apr 24, 2024
Closed
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…ync_Cancellation data race (dotnet#101428) * Fix SocketsHttpHandlerTest_HttpClientHandlerTest_Http3.ReadAsStreamAsync_Cancellation data race * Fix build
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…ync_Cancellation data race (dotnet#101428) * Fix SocketsHttpHandlerTest_HttpClientHandlerTest_Http3.ReadAsStreamAsync_Cancellation data race * Fix build
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…ync_Cancellation data race (dotnet#101428) * Fix SocketsHttpHandlerTest_HttpClientHandlerTest_Http3.ReadAsStreamAsync_Cancellation data race * Fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered in local runs
The connection was closed before the test loopback server managed to write response body. We can ignore the exception.