Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store last OSR transition context in static memory in DEBUG builds #101537

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Apr 25, 2024

Hopefully will help with diagnosing #101060 once we get a new dump.

Hopefully will help with diagnosing dotnet#101060 once we get a new dump.
@jakobbotsch jakobbotsch changed the title Avoid overwriting frame context in JIT_Patchpoint Store last OSR transition context in static memory in DEBUG builds Apr 25, 2024
@jakobbotsch jakobbotsch marked this pull request as ready for review April 25, 2024 14:34
@@ -5144,7 +5144,7 @@ void JIT_Patchpoint(int* counter, int ilOffset)
const int counterBump = g_pConfig->OSR_CounterBump();
*counter = counterBump;

#if _DEBUG
#ifdef _DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more of these just below.

@jakobbotsch jakobbotsch merged commit 74d9279 into dotnet:main Apr 25, 2024
89 checks passed
@jakobbotsch jakobbotsch deleted the osr-alloca branch April 25, 2024 16:56
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants