Arm64/Sve: Add SignExtendWidening* and ZeroExtendWidening* math APIs #101743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
|
@dotnet/arm64-contrib |
|
/ba-g Failure is #101721 |
This was referenced May 1, 2024
a74nh
reviewed
May 1, 2024
| @@ -2185,7 +2185,7 @@ void emitter::emitInsSve_R_R(instruction ins, | |||
| case INS_sve_uunpkhi: | |||
| case INS_sve_uunpklo: | |||
| assert(insScalableOptsNone(sopt)); | |||
| assert(insOptsScalableAtLeastHalf(opt)); | |||
There was a problem hiding this comment.
Does doing this break the unit tests? I would hope there are some H,S,D tests that need switching to B,H,S
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…otnet#101743) * Add SignExtendWidening* and ZeroExtendWidening* APIs * Map API to instruction * Add missing SignExtendWidening* APIs * Add test cases * fix bugs * Forgot to push the template * jit format * Fix the LargeVectorSize
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…otnet#101743) * Add SignExtendWidening* and ZeroExtendWidening* APIs * Map API to instruction * Add missing SignExtendWidening* APIs * Add test cases * fix bugs * Forgot to push the template * jit format * Fix the LargeVectorSize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests added are passing: https://gist.github.com/kunalspathak/7d2dc1578786410a45d39f54754af4a1
Contributes to #99957