JIT: Remove LSRA arm32 quirk #101791
Merged
JIT: Remove LSRA arm32 quirk #101791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For arm32 this query can return an earlier location if the upper half register assigned to a TYP_DOUBLE interval has an earlier ref.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jakobbotsch
commented
May 2, 2024
| @@ -5874,6 +5874,8 @@ void LinearScan::allocateRegisters() | |||
| continue; | |||
| } | |||
|
|
|||
| assert(!currentRefPosition.isPhysRegRef); | |||
There was a problem hiding this comment.
Also added this to match allocateRegistersMinimal (forgot it in the previous PR)
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib PTAL @kunalspathak No arm32 diffs, so apparently this quirk wasn't necessary after all. |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
For arm32 this query can return an earlier location if the upper half register assigned to a TYP_DOUBLE interval has an earlier ref.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
For arm32 this query can return an earlier location if the upper half register assigned to a TYP_DOUBLE interval has an earlier ref.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For arm32 this query can return an earlier location if the upper half register assigned to a TYP_DOUBLE interval has an earlier ref.