Adjust repro file message for merged test #102141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the script ./src/tests/run.py outputs "Failed to create repro for test" for a failed merged test. But this comment 1288 if assembly_is_merged_tests_run: 1289 # REVIEW: Even if the test is a .dll file or .CMD file and is found, we don't know how to 1290 # build a repro case with it. from ./src/test/run.py script says that for a merged test a repro file should not be created at all. Changing the message "Failed to create repro for test" to "Skipping repro for merged test".
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
clamp03
reviewed
May 13, 2024
am11
added
area-Infrastructure-coreclr
and removed
area-CodeGen-coreclr
|
Tagging subscribers to this area: @hoyosjs |
tomeksowi
approved these changes
May 13, 2024
|
@BruceForstall Could you review this PR? Thank you. |
sirntar
approved these changes
May 14, 2024
Bajtazar
approved these changes
May 15, 2024
|
@BruceForstall @jkotas Could you take a look? |
RISC-V test results for qemu-prio1-checked: 450 / 1045 (43.06%)detailsGIT: 5a6b372 failed testskilled testsskipped tests |
RISC-V test results for starfive-prio1-checked: 450 / 1045 (43.06%)detailsGIT: 5a6b372 failed testskilled testsskipped tests |
|
@BruceForstall @jkotas It adds an error message. I think it looks better. What do you think? Could you review and give any advice about error message string and variable name? Thank you. |
I am sorry I do not have a context on this script. |
jkoritzinsky
approved these changes
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust message about repro file for a merged test
For now the script
./src/tests/run.pyoutputs "Failed to create repro for test" for a failed merged test.But this comment
from
./src/test/run.pyscript says that for a merged test a repro file should not be created at all.Changing the message "Failed to create repro for test" to "Skipping repro for merged test".
Part of #84834, cc @dotnet/samsung