[QUIC] Validate Close/Abort errorCode parameter #102264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods for better reuse
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rzikm
approved these changes
May 15, 2024
| @@ -447,6 +447,8 @@ public void Abort(QuicAbortDirection abortDirection, long errorCode) | |||
| return; | |||
| } | |||
|
|
|||
| ThrowHelper.ValidateErrorCode(nameof(Abort), errorCode); | |||
There was a problem hiding this comment.
what about the compiler-filled parameter propertyName, won't it produce weird error message? Same for QuicConnection.CloseAsync
There was a problem hiding this comment.
Yeah, you're right: System.ArgumentOutOfRangeException: 'errorCode' should be within [0, 4611686018427387903) range. (Parameter 'CloseAsync')
Changed to: System.ArgumentOutOfRangeException: 'CloseAsync.errorCode' should be within [0, 4611686018427387903) range. (Parameter 'errorCode') obviously for both CloseAsync and Abort.
This was referenced May 15, 2024
ManickaP
force-pushed
the
quic-validate-error
branch
from
13ec061 to
c432881
Compare
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Validate Close/Abort errorCode parameter, shuffle around validation methods for better reuse * Remove unnecassary PNSE exclusion * Changed exception text and added tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also shuffle around validation methods for better reuse and fix typo.
Fixes #101385