LSRA: Refactor some of the methods around creating kill set #102469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib |
This was referenced May 21, 2024
jakobbotsch
approved these changes
May 21, 2024
|
@jakobbotsch - i fixed some riscv64 build errors. PTAL |
jakobbotsch
reviewed
May 21, 2024
| @@ -131,8 +131,8 @@ ABIPassingInformation RiscV64Classifier::Classify(Compiler* comp, | |||
| regNumber secondReg = (isSecondFloat ? m_floatRegs : m_intRegs).Dequeue(); | |||
|
|
|||
| return {2, new (comp, CMK_ABI) | |||
| ABIPassingSegment[]{ABIPassingSegment::InRegister(firstReg, 0, firstSize), | |||
| ABIPassingSegment::InRegister(secondReg, offset, secondSize)}}; | |||
| ABIPassingSegment[2]{ABIPassingSegment::InRegister(firstReg, 0, firstSize), | |||
There was a problem hiding this comment.
i get build error locally without it:
[ 68%] Building CXX object jit/CMakeFiles/clrjit_unix_riscv64_x64.dir/targetriscv64.cpp.o
/home/kpathak/git/runtime/src/coreclr/jit/targetriscv64.cpp: In member function ‘ABIPassingInformation RiscV64Classifier::Classify(Compiler*, var_types, ClassLayout*, WellKnownArg)’:
/home/kpathak/git/runtime/src/coreclr/jit/targetriscv64.cpp:165:46: error: expected primary-expression before ‘]’ token
165 | ABIPassingSegment[]{passSlot(0, TARGET_POINTER_SIZE),
| ^
/home/kpathak/git/runtime/src/coreclr/jit/targetriscv64.cpp:166:111: error: too many initializers for ‘ABIPassingSegment [1]’
166 | passSlot(TARGET_POINTER_SIZE, passedSize - TARGET_POINTER_SIZE)}};
| ^
make[3]: *** [jit/CMakeFiles/clrjit_unix_riscv64_x64.dir/build.make:1613: jit/CMakeFiles/clrjit_unix_riscv64_x64.dir/targetriscv64.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:2685: jit/CMakeFiles/clrjit_unix_riscv64_x64.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:1681: CMakeFiles/crosscomponents.dir/rule] Error 2
make: *** [Makefile:299: crosscomponents] Error 2
|
/ba-g failure is related to #102479 |
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
…02469) * refactor code around buildkill * fix build errors * some more errors * jit format * fix riscv64 * make retTypeDesc as noway_assert * fix riscv64 errors * jit format
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…02469) * refactor code around buildkill * fix build errors * some more errors * jit format * fix riscv64 * make retTypeDesc as noway_assert * fix riscv64 errors * jit format
This was referenced Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some refactoring and separated out the methods for the ones that create multiple defs vs. single def as well the one with create defs for call, and the ones that just build the
killMask.This is in preparation for the upcoming work I am doing to add support for predicate registers. This patch is extracted out from #98258