Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] Wrap Cancelled Request with OCE instead of QuicException #103081

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

liveans
Copy link
Member

@liveans liveans commented Jun 5, 2024

Fixes #98220

@liveans
Copy link
Member Author

liveans commented Jun 5, 2024

/azp list

Copy link

CI/CD Pipelines for this repository:

@liveans
Copy link
Member Author

liveans commented Jun 5, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Jun 5, 2024

/azp run runtime-libraries stress-http

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the one open comment.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please add some comments to your new cases similar to the comments in cases above in their respective methods.

@liveans
Copy link
Member Author

liveans commented Jun 18, 2024

/ba-g failures unrelated

@liveans liveans merged commit a3e728a into dotnet:main Jun 18, 2024
80 of 83 checks passed
@karelz karelz added this to the 9.0.0 milestone Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP/3] map QuicException to OCE in case of a cancellation
4 participants