Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new lock type in TimerQueue #103104

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

eduardo-vp
Copy link
Member

No description provided.

@eduardo-vp eduardo-vp requested a review from kouvel June 5, 2024 23:32
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 5, 2024
@eduardo-vp eduardo-vp added area-System.Threading and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion below. It would be nice to update the other lock in TimerQueue.Portable.cs as well. LGTM otherwise, thanks!

…r.cs

Co-authored-by: Koundinya Veluri <kouvel@users.noreply.github.com>
@eduardo-vp
Copy link
Member Author

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
Copy link
Member Author

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp eduardo-vp merged commit 7875486 into dotnet:main Jul 3, 2024
144 of 146 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants