Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-eol-versions-6.0-staging #103380

Conversation

richlander
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 12, 2024
@richlander richlander force-pushed the update-eol-versions-6.0-staging branch from 3fad07c to 9632d5e Compare June 12, 2024 22:46
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richlander thanks for submitting, this looks good.

Question: I am seeing some 6.0 PRs failing with this error too:

SENDHELIXJOB(0,0): error : Helix queue redhat.7.amd64.open is set for estimated removal date of 2024-06-30. In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions or concerns, and we can help you decide how to proceed and discuss other options.

Do you know what's the now supported version we should be using? This does not need to be addressed in this PR, can be done separately.

Aside from the above question, is this ready to merge? If yes, feel free to press the squash button.

@richlander
Copy link
Member Author

richlander commented Jul 7, 2024

Libraries tests are failing on Windows 10. Known issue: #104390.

    System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11 [FAIL]
      Assert.Throws() Failure
      Expected: typeof(System.Exception)
      Actual:   (No exception was thrown)
      Stack Trace:
        /_/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs(335,0): at System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11()
        --- End of stack trace from previous location ---

@wfurt

@richlander
Copy link
Member Author

Looks like something is wrong with either the infra or System.IO.Net5Compat.Tests and `System.IO.Tests' (or the underlying product areas).

@carlossanlop

@carlossanlop
Copy link
Member

/ba-g System.IO and System.IO.Net5Compat failure is a known/pre-existing issue that KnownBuildError was unable to link: #100558

@richlander richlander merged commit ff43d78 into dotnet:release/6.0-staging Jul 16, 2024
114 of 125 checks passed
@richlander richlander deleted the update-eol-versions-6.0-staging branch July 16, 2024 19:06
- (Ubuntu.1804.Arm32)Ubuntu.1804.Armarch@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7
- (Debian.12.Arm32)Ubuntu.2204.Armarch@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-12-helix-arm32v7
- (Debian.11.Arm32)Ubuntu.2204.ArmArch@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-arm32v7
- (Ubuntu.2004.Arm32)Ubuntu.1804.Armarch@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct, the value in parens is just a display name. the actual docker image is still using 18.04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this and the other one. I'll take a look at both later today and fix the mistakes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants