[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

lambdageek · 2024-06-13T19:58:45Z

Contributes to #99302

Also updates the existing DAC so that it does not store an EEClass* in DacpMethodTableData::Class, but instead stores a pointer to the canonical method table. Correspondingly GetMethodTableForEEClass now expects a canonical MethodTable.

Also renamed MethodTable::ContainsPointers to ContainsGCPointers, (and corresponding flag and setter method); also updated gcenv for NativeAOT with the same renaming.

Also changed the existing DAC so that DacpMethodTableData::wNumVirtuals and DacpMethodTableData::wNumVtableSlots are always returned as 0. The cDAC Metadata contract does not expose the underlying info

verified that it works for at least one MethodTable by running some manual WinDbgX test

TODO:

write the contract in docs/
unit tests

…-wip

dotnet-policy-service · 2024-06-13T19:59:16Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

src/native/managed/cdacreader/src/Contracts/Metadata.cs

lambdageek · 2024-06-14T14:32:42Z

Need to reconcile with #99183 - I was on an older branch

update updated and fixed the merge issues. Validated that GetMethodTableData is still functional

src/native/managed/cdacreader/src/Contracts/Metadata.MethodTableFlags.cs

docs/design/datacontracts/Metadata.md

src/native/managed/cdacreader/src/Contracts/Metadata_1.cs

src/native/managed/cdacreader/src/Data/EEClass.cs

src/native/managed/cdacreader/src/Data/MethodTable.cs

src/coreclr/gc/env/gcenv.object.h

src/native/managed/cdacreader/src/Contracts/Metadata_1.cs

src/native/managed/cdacreader/src/Contracts/Metadata_1.MethodTableFlags.cs

src/native/managed/cdacreader/src/Contracts/Metadata_1.cs

1. rename AttrClass data descriptor field to CorTypeAttr 2. fixup HasComponentSize / RawGetComponentSize comments and code 3. update "system.object" mock methodtable with more field values 4. update "system.string" mock methodtable with more field values

Co-authored-by: Elinor Fung <elfung@microsoft.com>

…ableFlags.cs Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-07-02T20:31:00Z

I was asked to rename the contract from Metadata to something else because CoreCLR doesn't really use "metadata" to talk about the execution-time type identity of managed objects. The obvious alternative name for the contract is MethodTable, but I'm open to other options.

jkotas · 2024-07-02T20:38:45Z

Naming suggestion: TypeSystem or RuntimeTypeSystem

AaronRobinsonMSFT · 2024-07-02T21:33:27Z

Naming suggestion: TypeSystem or RuntimeTypeSystem

I prefer RuntimeTypeSystem.

…ionException

davidwrighton · 2024-07-03T17:23:47Z

src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.cs

+    private readonly Target _target;
+    private readonly TargetPointer _freeObjectMethodTablePointer;
+
+    // TODO(cdac): we mutate this dictionary - copies of the Metadata_1 struct share this instance.


Support for invalidating our view of memory and re-reading to fill in the world should be a pretty soon now project, but I'm ok with having checking in the current state here, and fixing it later when we add that support.

src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.cs

…1.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

lambdageek · 2024-07-03T20:24:51Z

I now have unit tests for MethodTable validation and access for things that look like: System.Object, System.String, a methodTable with a garbage EEClass, a generic instance (and its generic definition), an array of some valuetype. This covers a variety of paths throughValidateMethodTablePointer.

Doing more testing is difficult until we have more query methods and data descriptors to mock something more interesting.

I'd like to finish up with this PR and get into expanding the contract for the next SOS API (most likely GetMethodTableName)

elinor-fung and others added 19 commits May 17, 2024 16:12

Implement GetThreadStoreData in cDAC

b98afa8

Add placeholder for getting thread data

890f9c6

Apply suggestions from code review

41ba95c

WIP: Metadata contract

29214f0

Merge remote-tracking branch 'elinor-fung/cdac-threadstore' into cdac…

8beced0

…-wip

fix build

5213286

WIP: ValidateMethodTable

622e01a

DataCache.GetOrAdd

e112416

wip

ae1eac9

Merge remote-tracking branch 'elinor-fung/cdac-threadstore' into cdac…

79ea0d4

…-wip

checkpoint: ValidateWithPossibleAV

5c696da

Merge remote-tracking branch 'origin/main' into cdac-wip

6eaf80f

checkpoint EEClass from MethodTable

3a7808d

checkpoint: ValidateMethodTablePointer

66e5476

cp: delegate from legacy dac

95914b8

add Metadata to runtime contract descriptor

2b8fda3

checkpoint: more MethodTable fields

5c7d2ac

checkpoint GetMethodTableData implemented

7be5c60

checkpoint: same answer as legacy dac

30b7b26

dotnet-issue-labeler bot added the area-Diagnostics-coreclr label Jun 13, 2024

dotnet-policy-service bot assigned lambdageek Jun 13, 2024

lambdageek commented Jun 13, 2024

View reviewed changes

src/native/managed/cdacreader/src/Contracts/Metadata.cs Outdated Show resolved Hide resolved

lambdageek commented Jun 13, 2024

View reviewed changes

src/native/managed/cdacreader/src/Contracts/Metadata.cs Outdated Show resolved Hide resolved

lambdageek mentioned this pull request Jun 13, 2024

[cdac] Implement !PrintException #99302

Open

25 tasks

lambdageek marked this pull request as draft June 14, 2024 14:32

lambdageek added 2 commits June 14, 2024 10:52

Merge remote-tracking branch 'origin/main' into cdac-wip

187bcbe

new flags for statics

f0d1fcb

jkotas reviewed Jun 14, 2024

View reviewed changes

src/native/managed/cdacreader/src/Contracts/Metadata.MethodTableFlags.cs Outdated Show resolved Hide resolved

validate that a mock system object is a valid method table

f9bce4c

AaronRobinsonMSFT reviewed Jul 2, 2024

View reviewed changes

elinor-fung reviewed Jul 2, 2024

View reviewed changes

lambdageek and others added 6 commits July 2, 2024 15:22

Update src/coreclr/gc/env/gcenv.object.h

1af7c80

Co-authored-by: Elinor Fung <elfung@microsoft.com>

Update src/native/managed/cdacreader/src/Contracts/Metadata_1.MethodT…

993ae1d

…ableFlags.cs Co-authored-by: Elinor Fung <elfung@microsoft.com>

Address code review feedback

f04d880

move non-validated MethodTable handling to a separate class

76859d1

clear up ComponentSize contract spec and impl

a12a407

This was referenced Jul 3, 2024

ProcessThreadTests.TestStartTimeProperty failed in CI #103448

Closed

The "RestoreTask" task returned false but did not log an error dotnet/dnceng#3100

Open

rename Metadata -> RuntimeTypeSystem

9cf4c5a

lambdageek changed the title ~~[cdac] start of Metadata contract; implement GetMethodTableData SOS method~~ [cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method Jul 3, 2024

lambdageek added 2 commits July 3, 2024 11:49

add validation failure test; change validation to throw InvalidOperat…

1814848

…ionException

Merge remote-tracking branch 'origin/main' into cdac-wip

89f98a3

davidwrighton reviewed Jul 3, 2024

View reviewed changes

jkotas reviewed Jul 3, 2024

View reviewed changes

src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.cs Outdated Show resolved Hide resolved

lambdageek and others added 4 commits July 3, 2024 15:10

Update src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_…

a0989fa

…1.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

spellcheck

617bf62

Merge branch 'cdac-wip' of github.com:lambdageek/runtime into cdac-wip

815ff0d

Add a generic instance test

1ab4f08

add array instance test

ee3a362

lambdageek force-pushed the cdac-wip branch from b058fac to ee3a362 Compare July 3, 2024 20:29

davidwrighton approved these changes Jul 3, 2024

View reviewed changes

lambdageek merged commit e336326 into dotnet:main Jul 8, 2024
151 checks passed

github-actions bot locked and limited conversation to collaborators Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

lambdageek commented Jun 13, 2024 •

edited

Loading

dotnet-policy-service bot commented Jun 13, 2024

lambdageek commented Jun 14, 2024 •

edited

Loading

lambdageek commented Jul 2, 2024

jkotas commented Jul 2, 2024

AaronRobinsonMSFT commented Jul 2, 2024

davidwrighton Jul 3, 2024

lambdageek commented Jul 3, 2024

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

Conversation

lambdageek commented Jun 13, 2024 • edited Loading

dotnet-policy-service bot commented Jun 13, 2024

lambdageek commented Jun 14, 2024 • edited Loading

lambdageek commented Jul 2, 2024

jkotas commented Jul 2, 2024

AaronRobinsonMSFT commented Jul 2, 2024

davidwrighton Jul 3, 2024

Choose a reason for hiding this comment

lambdageek commented Jul 3, 2024

lambdageek commented Jun 13, 2024 •

edited

Loading

lambdageek commented Jun 14, 2024 •

edited

Loading